Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create HIPSCAT_ID_MAX constant #181

Merged
merged 4 commits into from
Dec 8, 2023
Merged

Conversation

camposandro
Copy link
Contributor

Creates a HIPSCAT_ID_MAX constant (the maximum value for uint64) that is useful to compute catalog divisions. It also fixes the argument types for methods on the hipscat_id module.

Relates to PR !79.

  • My PR includes a link to the issue that I am addressing

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

@camposandro camposandro self-assigned this Dec 8, 2023
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b4fa8fd) 99.70% compared to head (dc7fc2f) 99.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #181   +/-   ##
=======================================
  Coverage   99.70%   99.70%           
=======================================
  Files          51       51           
  Lines        1688     1691    +3     
=======================================
+ Hits         1683     1686    +3     
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 8, 2023

Before [b4fa8fd] After [383f609] Ratio Benchmark (Parameter)
638±4ms 641±2ms 1 benchmarks.Suite.time_pixel_tree_creation
121±0.7ms 121±0.5ms 1 benchmarks.time_test_alignment_even_sky
100±2ms 98.6±0.2ms 0.98 benchmarks.time_test_cone_filter_multiple_order

Click here to view all benchmarks.

@camposandro camposandro marked this pull request as draft December 8, 2023 18:44
@camposandro camposandro marked this pull request as ready for review December 8, 2023 19:07
@camposandro camposandro merged commit a313710 into main Dec 8, 2023
10 checks passed
@camposandro camposandro deleted the sandro/add-hipscat-id-max branch January 11, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants