Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally include protocol prefix in file match. #178

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

In service of astronomy-commons/hats-import#177. Matching paths must also contain the original filesystem protocol in order to read the files.

Copy link

github-actions bot commented Dec 4, 2023

Before [0c42a60] <v0.1.7> After [69a9e77] Ratio Benchmark (Parameter)
646±5ms 649±7ms 1.01 benchmarks.Suite.time_pixel_tree_creation
95.9±0.3ms 95.7±0.7ms 1 benchmarks.time_test_cone_filter_multiple_order
118±1ms 116±0.6ms 0.98 benchmarks.time_test_alignment_even_sky

Click here to view all benchmarks.

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0c42a60) 99.70% compared to head (d06489d) 99.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #178   +/-   ##
=======================================
  Coverage   99.70%   99.70%           
=======================================
  Files          51       51           
  Lines        1681     1684    +3     
=======================================
+ Hits         1676     1679    +3     
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jeremykubica jeremykubica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Added one possible change for the test.

@delucchi-cmu delucchi-cmu merged commit 11a8182 into main Dec 4, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants