Allow to tag sent messages with same tags as message being replied to #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauteh
reviewed
Oct 21, 2018
|
|
||
| if (!parent_mid.empty () && | ||
| find(additional_sent_tags.begin(), additional_sent_tags.end(), "*") != additional_sent_tags.end()) { | ||
| notmuch_message_t * parent_msg; |
There was a problem hiding this comment.
Probably better to use on_message here, takes care of cleaning up the parent_msg. Might also be better to instantiate a NotmuchMessage on parent_msg, there is already a get_tags function which is more robust. NotmuchMessage should be cheap objects.
There was a problem hiding this comment.
Thanks, I'll have a look at that.
2 tasks
|
Lars Kotthoff writes on October 20, 2018 21:56:
This PR introduces special values to `accounts.<account>.additional_sent_tags`, namely '*' (apply all tags that the message being replied to, if any, has), and '-<tag>' (to exclude tags from being applied). For example, the option "foo,*,-attachment" applies the tag "foo" and any tags the message being replied to has, except for "attachment".
Does the syntax also work for the general `mail.sent_tags`?
|
|
Good idea, I'll add that. |
|
I've changed the code to use |
|
Lars Kotthoff writes on October 22, 2018 18:04:
I've changed the code to use `NotmuchMessage`. Turns out that this syntax for the general `mail.sent_tags` was already supported because I'm doing the processing after merging in those tags.
Merged, thanks. Sorry for the delay. Could you please update the
configuration reference for the two relevant config options?
|
|
Thanks, done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces special values to
accounts.<account>.additional_sent_tags, namely*(apply all tags that the message being replied to, if any, has), and-<tag>(to exclude tags from being applied). For example, the option "foo,*,-attachment" applies the tag "foo" and any tags the message being replied to has, except for "attachment".