Warn users on "~=" python-version #8284
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianpaul10
commented
Oct 17, 2024
| ("~=3.11", true), | ||
| ("~=2.7", true), | ||
| ("~=3.10, <3.11", false), | ||
| ("~=3.10, <=3.11", false), |
There was a problem hiding this comment.
While unlikely, this sort of version should not throw a warning, correct?
There was a problem hiding this comment.
We can leave it without a warning. It's an odd version specifier to write and likely not what the user intended, but it's not one that specifically matches this case.
ianpaul10
force-pushed
the
feat/warn-on-tilde-eq
branch
from
b49f5bd to
4106f9a
Compare
ianpaul10
force-pushed
the
feat/warn-on-tilde-eq
branch
from
4106f9a to
6930710
Compare
ianpaul10
changed the title
|
Hey @ianpaul10, I updated this with
cc @BurntSushi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #7426
Second part of #7426, that checks if the python-version uses a tilde eq without a patch version (e.g.
~=3.11, which will be interpreted as>=3.10, ==3.*) and warns the user, asking them to specify a patch version.Test Plan
Unit tests were added for
is_tilde_exact_without_patch