Allow uv pip sync to clear an environment with opt-in
#4517
Conversation
crates/uv-cli/src/lib.rs
Outdated
|
|
||
| /// Allow sync of empty requirements, which will clear the environment of all packages. | ||
| #[arg(long, overrides_with("no_allow_empty_requirements"))] | ||
| pub allow_empty_requirements: bool, |
There was a problem hiding this comment.
I would prefer --allow-empty, I don't think it's ambiguous.
I think this also needs to be added to the PipOptions and respected in persistent configuration, and it should probably be accepted on pip install too? Though not sure what it would mean in that case so maybe not.
There was a problem hiding this comment.
If pip install exits with success when the requirements are empty I don't think it would mean anything there.
I can shorten it, though I find it a bit ambiguous.
There was a problem hiding this comment.
I guess it makes sense to include in the persistent configuration too? It only seems relevant for this command though.
There was a problem hiding this comment.
Yeah it should be in the persistent configuration -- that's the contract for the pip table (e.g., it includes things that only apply to pip-compile).
There was a problem hiding this comment.
I find --allow-empty-requirements to be more verbose than necessary but not a strong opinion, it's fine.
|
@zanieb - I'll add to config and merge. |
|
@charliermarsh thanks! |
|
Sorry got too excited |
charliermarsh
force-pushed
the
zb/sync-allow-empty
branch
from
15e9dc7 to
a361c69
Compare
Closes #4516
Open to some deliberation about the opt-in strategy here.