Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[red-knot] Minor refactor of red_knot_vendored/build.rs #15372

Merged
merged 1 commit into from
Jan 9, 2025
Merged

[red-knot] Minor refactor of red_knot_vendored/build.rs #15372

merged 1 commit into from
Jan 9, 2025

Conversation

sharkdp
Copy link
Contributor

@sharkdp sharkdp commented Jan 9, 2025

Summary

See #15370 (comment):

  • Rename zip_dir to write_zipped_typeshed_to to clarify it's not a generic function (anymore)
  • Hard-code TYPESHED_SOURCE_DIR instead of using a directory_path argument

@sharkdp sharkdp added the red-knot Multi-file analysis & type inference label Jan 9, 2025
@sharkdp sharkdp added the internal An internal refactor or improvement label Jan 9, 2025
@sharkdp sharkdp mentioned this pull request Jan 9, 2025
Merged
AlexWaygood
AlexWaygood approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@sharkdp sharkdp enabled auto-merge (squash) January 9, 2025 12:21
@sharkdp sharkdp merged commit bf5b0c2 into main Jan 9, 2025
20 checks passed
@sharkdp sharkdp deleted the david/zip-typeshed-dir branch January 9, 2025 12:23
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@carljm carljm Awaiting requested review from carljm carljm is a code owner

@MichaReiser MichaReiser Awaiting requested review from MichaReiser MichaReiser is a code owner

Assignees
No one assigned
Labels
internal An internal refactor or improvement red-knot Multi-file analysis & type inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sharkdp @AlexWaygood