Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flake8-django] Recognize other magic methods (DJ012) #15365

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

InSyncWithFoo
Copy link
Contributor

Summary

Resolves #13892.

Test Plan

cargo nextest run and cargo insta test.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@dhruvmanila dhruvmanila added rule Implementing or modifying a lint rule breaking Breaking API change labels Jan 9, 2025
@dhruvmanila dhruvmanila added this to the v.0.10 milestone Jan 9, 2025
@MichaReiser MichaReiser added do-not-merge Do not merge this pull request and removed do-not-merge Do not merge this pull request labels Jan 9, 2025
@MichaReiser
Copy link
Member

I think we have three options here:

  • We change it to preview only so that we can merge it here
  • We leave it as is and wait for the 0.10 release to merge it
  • We merge it as is because we mainly consider this a bugfix.

I'm leaning toward classifying this as a bugfix and releasing it as part of 0.9 (CC: @AlexWaygood)

@AlexWaygood
Copy link
Member

I'm leaning toward classifying this as a bugfix and releasing it as part of 0.9 (CC: @AlexWaygood)

Yeah, that makes sense to me!

@MichaReiser MichaReiser removed the breaking Breaking API change label Jan 9, 2025
@MichaReiser MichaReiser merged commit 8bc11c4 into astral-sh:main Jan 9, 2025
21 checks passed
@AlexWaygood AlexWaygood modified the milestones: v0.10, v0.9 Jan 9, 2025
@InSyncWithFoo InSyncWithFoo deleted the DJ012 branch January 9, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rule Implementing or modifying a lint rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DJ012 produces false positive when there are other dunder methods in model class
4 participants