[red-knot] Print non-string panic payloads and (sometimes) backtraces #15363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcreager
requested review from
carljm,
MichaReiser,
AlexWaygood and
sharkdp
as code owners
dcreager
commented
Jan 8, 2025
Comment on lines
-6
to
+8
| pub info: String, | ||
| pub location: Option<String>, | ||
| pub payload: Option<String>, |
There was a problem hiding this comment.
Note that we can't put the actual payload here, because what we get back is a reference to a dyn Any, and that does not guarantee that the payload is cloneable.
Comment on lines
+151
to
+153
| // Mimic the default panic hook's rendering of the panic payload if it's | ||
| // not a string. | ||
| None => messages.push("Box<dyn Any>".to_string()), |
There was a problem hiding this comment.
So instead we just mimic the output of the default panic hook here if the payload is not a string. (Note that neither us nor std::panic can print out anything more meaningful, since you can only downcast Any to specific known types, not to traits like Display or Debug)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More refinements to the panic messages for failing mdtests to mimic the output of the default panic hook more closely:
Box<dyn Any>if the panic payload is not a string (which is typically the case for salsa panics).RUST_BACKTRACEenvironment variable.