Fix for message not being displayed in assert methods #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulrikhindoe
changed the title
|
Hey @ulrikhindoe! Awesome stuff, thanks 😊 Just FYI, this was not a bug, I just never implemented that part. I'm curious I never (or anyone else really) opened an issue for it. |
astorije
requested changes
Nov 22, 2017
There was a problem hiding this comment.
Hey @ulrikhindoe, would you mind adding this for other methods to, like the core Chai?
| @@ -689,14 +689,14 @@ | |||
| * @api public | |||
There was a problem hiding this comment.
Could you add the doc for these additions please?
Similarly to this, after * @param {Collection} expected, that would be * @param {String} message _optional_
|
Closing this as it's now outdated and needs a little work. I opened #207 to keep track of the feature request, if anyone wants to help 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When given as an argument the message should be displayed when the assertion fails like is does when
chai is being used without chai-immutable.
It has been fixed for these methods:
assert.equal(actual, expected, message)
assert.notEqual(actual, expected, message)
assert.sizeOf(collection, expected, message)