Fix and improve duplicates #240
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| dup += 1 | ||
|
|
||
| if dup == 13 | ||
| value_dups.push("Faturas: #{det.css('nDup').text} - #{format_dup_date(det, det.css('dVenc').text)} - R$ #{BrDanfe::Helper.numerify(det.css('vDup').text.to_f)}") |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| if dup == 13 | ||
| value_dups.push("Faturas: #{det.css('nDup').text} - #{format_dup_date(det, det.css('dVenc').text)} - R$ #{BrDanfe::Helper.numerify(det.css('vDup').text.to_f)}") | ||
| elsif dup > 13 | ||
| value_dups.push("#{det.css('nDup').text} - #{format_dup_date(det, det.css('dVenc').text)} - R$ #{BrDanfe::Helper.numerify(det.css('vDup').text.to_f)}") |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| @@ -388,6 +479,78 @@ | |||
| <pesoB>3300.000</pesoB> | |||
| </vol> | |||
| </transp> | |||
| <cobr> | |||
|
|
||
| render_titles_and_box(x, y) | ||
| det_count = 0 | ||
|
|
||
| @xml.collect('xmlns', 'dup') do |det| |
There was a problem hiding this comment.
Recomendo filtrar a coleção, usando por exemplo, filtro por range.
Inclusive, remover o uso da variável det_count para usar o index do próprio loop.
Examplo:
@xml.collect('xmlns', 'dup')[..12].each_with_index do |det|
endThere was a problem hiding this comment.
Defina uma constante: DUP_MAX_QUANTITY = 12.
Devido ao comportamento do método collect a sugestão acima precisa ser ajustada para:
@xml.collect('xmlns', 'dup') { _1 }[..DUP_MAX_QUANTITY - 1].each do |det|
endUse no outro local que faz esse loop também.
| dup = 0 | ||
| value_dups = [] | ||
|
|
||
| @xml.collect('xmlns', 'dup') do |det| |
There was a problem hiding this comment.
Recomendo filtrar a coleção, usando por exemplo, filtro por range.
Inclusive, remover o uso da variável dup para usar o index do próprio loop.
Examplo:
@xml.collect('xmlns', 'dup')[13..].each_with_index do |det|
end
| dup += 1 | ||
| value = "#{det.css('nDup').text} - #{format_dup_date(det, det.css('dVenc').text)} - R$ #{BrDanfe::Helper.numerify(det.css('vDup').text.to_f)}" | ||
|
|
||
| if dup == 13 |
There was a problem hiding this comment.
Use a constante definida
| if dup == 13 | |
| if dup == BrDanfe::DanfeLib::NfeLib::Dup::DUP_MAX_QUANTITY |
|
|
||
| render_titles_and_box(x, y) | ||
| det_count = 0 | ||
|
|
||
| @xml.collect('xmlns', 'dup') do |det| |
There was a problem hiding this comment.
Defina uma constante: DUP_MAX_QUANTITY = 12.
Devido ao comportamento do método collect a sugestão acima precisa ser ajustada para:
@xml.collect('xmlns', 'dup') { _1 }[..DUP_MAX_QUANTITY - 1].each do |det|
endUse no outro local que faz esse loop também.
|
Code Climate has analyzed commit fd439b5 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (99% is the threshold). This pull request will bring the total coverage in the repository to 99.5% (0.0% change). View more on Code Climate. |
No description provided.