Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop the expiry time check in _validateMethod for http requests #180

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

brionmario
Copy link
Member

@brionmario brionmario commented Aug 22, 2024

Purpose

ATM, before the httpRequest is invoked, we do a validation check on the user's authentication status.

But a recent addition is added to the isAuthenticated() method to validate the access token expiry date as well.
This works for checking the authenticated status of the user but when the token is invalid, httpRequest method has the capability to refresh the token but that logic is newer reached due to await this._validateMethod(config.attachToken);

Goals

Fixes:

Approach

Disable the expiry time checking logic from httpRequest methods.

@brionmario brionmario merged commit f6f2d1e into asgardeo:main Aug 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants