Handle 401 failures gracefully #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonOmalVindula
requested review from
brionmario,
NipuniBhagya,
inthirakumaaran and
jeradrutnam
as code owners
brionmario
previously approved these changes
Apr 9, 2024
brionmario
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$subject
This will improve the token refresh logic to block the HTTP requests until the token is properly refreshed.
Because of this improvement, there is no requirement to periodically refresh the token in the application as the token will be refreshed on demand.
Therefore this will also introduce a config
periodicTokenRefreshwhich will be set tofalseby default. If a user wishes to enable periodic refresh of the token, they can set ittrueand it will work as intendedGoals
Resolves #166
Related PRs