Merge pull request #236 from Yasasr1/use-client-id

Send client_id in logout request
asgardeo · Oct 2, 2023 · 595750c · 595750c
2 parents f1ca1cf + 48a90cc
commit 595750c
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 11 deletions.
diff --git a/README.md b/README.md
@@ -985,6 +985,7 @@ This model has the following attributes.
 |`validateIDToken`|Optional| `boolean`|`true`|Allows you to enable/disable JWT ID token validation after obtaining the ID token.|
 |`clockTolerance`|Optional| `number`|`60`|Allows you to configure the leeway when validating the id_token.|
 |`sendCookiesInRequests`|Optional| `boolean`|`true`|Specifies if cookies should be sent in the requests.|
+|`sendIdTokenInLogoutRequest`|Optional| `boolean`|`false`|Specifies if `id_token_hint` parameter should be sent in the logout request instead of the default `client_id` parameter.|
 
 The `AuthClientConfig<T>` can be extended by passing an interface as the generic type. For example, if you want to add an attribute called `foo` to the config object, you can create an interface called `Bar` and pass that as the generic type into the `AuthClientConfig<T>` interface.
 

diff --git a/lib/src/core/authentication-core.ts b/lib/src/core/authentication-core.ts
@@ -546,16 +546,6 @@ export class AuthenticationCore<T> {
             );
         }
 
-        const idToken: string = (await this._dataLayer.getSessionData(userID))?.id_token;
-
-        if (!idToken || idToken.trim().length === 0) {
-            throw new AsgardeoAuthException(
-                "JS-AUTH_CORE-GSOU-NF02",
-                "ID token not found.",
-                "No ID token could be found. Either the session information is lost or you have not signed in."
-            );
-        }
-
         const callbackURL: string = configData?.signOutRedirectURL ?? configData?.signInRedirectURL;
 
         if (!callbackURL || callbackURL.trim().length === 0) {
@@ -567,9 +557,24 @@ export class AuthenticationCore<T> {
             );
         }
 
+        let parameter: string = `client_id=${ configData.clientID }`;
+
+        if (configData.sendIdTokenInLogoutRequest) {
+            const idToken: string = (await this._dataLayer.getSessionData(userID))?.id_token;
+
+            if (!idToken || idToken.trim().length === 0) {
+                throw new AsgardeoAuthException(
+                    "JS-AUTH_CORE-GSOU-NF02",
+                    "ID token not found.",
+                    "No ID token could be found. Either the session information is lost or you have not signed in."
+                );
+            }
+            parameter = `id_token_hint=${ idToken }`;
+        }
+
         const logoutCallback: string =
             `${ logoutEndpoint }?` +
-            `id_token_hint=${ idToken }` +
+            parameter +
             `&post_logout_redirect_uri=${ callbackURL }&state=` +
             SIGN_OUT_SUCCESS_PARAM;
 

diff --git a/lib/src/models/client-config.ts b/lib/src/models/client-config.ts
@@ -40,6 +40,7 @@ export interface DefaultAuthClientConfig {
   *
   */
   sendCookiesInRequests?: boolean;
+  sendIdTokenInLogoutRequest?: boolean;
 }
 
 export interface WellKnownAuthClientConfig extends DefaultAuthClientConfig {
-Original file line number
+Diff line change
@@ Expand Up / @@ -40,6 +40,7 @@ export interface DefaultAuthClientConfig { @@
       *
       */
       sendCookiesInRequests?: boolean;
+      sendIdTokenInLogoutRequest?: boolean;
     }
     export interface WellKnownAuthClientConfig extends DefaultAuthClientConfig {
@@ Expand Down @@