Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use start index in subset logic for UGRID #38

Merged
merged 5 commits into from
Jun 26, 2024
Merged

Use start index in subset logic for UGRID #38

merged 5 commits into from
Jun 26, 2024

Conversation

mpiannucci
Copy link
Collaborator

@mpiannucci mpiannucci commented Jun 26, 2024 •
edited
Loading

  • Some formatting
  • Use start_index in subsetting logic
  • Handle existing node and face coordinates in ugrid topology inference

Finishes off #37
Closes #32

@mpiannucci mpiannucci marked this pull request as draft June 26, 2024 15:22
@mpiannucci mpiannucci marked this pull request as ready for review June 26, 2024 15:42
@mpiannucci mpiannucci merged commit 9c9808b into main Jun 26, 2024
9 checks passed
@mpiannucci mpiannucci deleted the use-start-index branch June 26, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support zero and one based indexing:
2 participants
@mpiannucci @ChrisBarker-NOAA