Initial CR #2
Closed
Initial CR #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: HenryL27 <[email protected]>
Signed-off-by: HenryL27 <[email protected]>
Signed-off-by: HenryL27 <[email protected]>
Signed-off-by: HenryL27 <[email protected]>
Signed-off-by: HenryL27 <[email protected]>
Signed-off-by: HenryL27 <[email protected]>
Signed-off-by: HenryL27 <[email protected]>
Signed-off-by: HenryL27 <[email protected]>
Signed-off-by: HenryL27 <[email protected]>
Signed-off-by: HenryL27 <[email protected]>
Signed-off-by: HenryL27 <[email protected]>
Signed-off-by: HenryL27 <[email protected]>
Signed-off-by: HenryL27 <[email protected]>
Signed-off-by: HenryL27 <[email protected]>
Signed-off-by: HenryL27 <[email protected]>
Signed-off-by: HenryL27 <[email protected]>
Signed-off-by: HenryL27 <[email protected]>
Signed-off-by: HenryL27 <[email protected]>
Signed-off-by: HenryL27 <[email protected]>
Signed-off-by: HenryL27 <[email protected]>
* initial plugin test Signed-off-by: HenryL27 <[email protected]> * add factory tests Signed-off-by: HenryL27 <[email protected]> * add happy path unit tests for prototranslation utils Signed-off-by: HenryL27 <[email protected]> --------- Signed-off-by: HenryL27 <[email protected]>
austintlee
approved these changes
Feb 8, 2024
| // Serialize the request, response, context, and then send it to endpoint. | ||
| // Wait for response, deserialize it, and return it. | ||
| ProcessResponseRequest grpcRequest = buildRequest(request, response, ctx); | ||
| System.out.println(grpcRequest.toString()); |
| super(tag, description, ignoreFailure); | ||
| this.endpoint = endpoint; | ||
| this.processorName = processorName; | ||
| ChannelCredentials creds = InsecureChannelCredentials.create(); |
There was a problem hiding this comment.
"Insecure" as in no SSL? Or does it mean something else?
There was a problem hiding this comment.
no ssl, no app creds, no nothin. https://grpc.github.io/grpc-java/javadoc/io/grpc/ChannelCredentials.html
* create rest client as autocloseable in try Signed-off-by: HenryL27 <[email protected]> * install protoc as part of ci workflow Signed-off-by: HenryL27 <[email protected]> * add explicit generateProto task dependency to compile tasks Signed-off-by: HenryL27 <[email protected]> * add github token to protoc download for rate limiting reasons? Signed-off-by: HenryL27 <[email protected]> * add build/generated/... as source sets Signed-off-by: HenryL27 <[email protected]> * try using corretto instead of temurin Signed-off-by: HenryL27 <[email protected]> * revert to temurin Signed-off-by: HenryL27 <[email protected]> * add generateProto to workflow Signed-off-by: HenryL27 <[email protected]> * add recursive submodule checkout Signed-off-by: HenryL27 <[email protected]> * pluginIT from IntegTestCase to RestTestCase Signed-off-by: HenryL27 <[email protected]> * revert unnecessary changes Signed-off-by: HenryL27 <[email protected]> * add remotely run integration tests Signed-off-by: HenryL27 <[email protected]> * fix workflow names and run dispatch on PRs too Signed-off-by: HenryL27 <[email protected]> * add ref to dispatch request Signed-off-by: HenryL27 <[email protected]> * use head sha, not some weird intermediate PR sha Signed-off-by: HenryL27 <[email protected]> --------- Signed-off-by: HenryL27 <[email protected]>
Signed-off-by: HenryL27 <[email protected]>
Signed-off-by: HenryL27 <[email protected]>
* update maintainers, license, apply spotless Signed-off-by: HenryL27 <[email protected]> * update CODEOWNERS Signed-off-by: HenryL27 <[email protected]> * always use Aryn, Inc. Signed-off-by: HenryL27 <[email protected]> * remove snark Signed-off-by: HenryL27 <[email protected]> --------- Signed-off-by: HenryL27 <[email protected]>
|
closing as this pr only exists to be approved, not merged. 2.12 branch should be a clone of 2.x but only once we're stable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably more unit testing needs to be done; I haven't done any testing on the grpc stuff - but that mostly belongs in integration tests I think