Merge pull request #339 from superandrew213/development-react-native

Handle sessionId not defined case in cancel method of AbstractSession
arthenica · Feb 2, 2022 · fd351b7 · fd351b7
2 parents f4817da + cb12474
commit fd351b7
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/react-native/src/index.js b/react-native/src/index.js
@@ -669,11 +669,12 @@ export class AbstractSession extends Session {
   }
 
   /**
-   * Cancels running the session.
+   * Cancels running the session. Only starts cancellation. Does not guarantee that session is cancelled when promise resolves.
    */
-  cancel() {
+  async cancel() {
+    const sessionId = this.getSessionId();
     if (sessionId === undefined) {
-      return FFmpegKitReactNativeModule.cancel();
+      return Promise.reject(new Error('sessionId is not defined'));
     } else {
       return FFmpegKitReactNativeModule.cancelSession(sessionId);
     }