Skip to content

Commit

Permalink
fix: popup menus not working on mobile apps (#116)
Browse files Browse the repository at this point in the history
  • Loading branch information
regevbr authored Jun 13, 2023
1 parent a1f4885 commit 6ba7849
Show file tree
Hide file tree
Showing 6 changed files with 529 additions and 504 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
r="${r//$'\r'/'%0D'}" # Multiline escape sequences for '\r'
echo "::set-output name=RELEASE_BODY::$r"
- name: Upload the release file
uses: svenstaro/upload-release-action@v2.6.0
uses: svenstaro/upload-release-action@2.6.1
with:
file: dist/*
file_glob: true
Expand Down
1,002 changes: 515 additions & 487 deletions package-lock.json

Large diffs are not rendered by default.

12 changes: 6 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "mini-humidifier",
"version": "v3.1.4",
"version": "v3.1.5",
"description": "humidifier card for Home Assistant Lovelace UI",
"keywords": [
"home-assistant",
Expand All @@ -17,11 +17,11 @@
"author": "Artem Sedykh <[email protected]>",
"license": "MIT",
"dependencies": {
"@lit-labs/scoped-registry-mixin": "^1.0.0",
"@material/mwc-list": "^0.25.3",
"@material/mwc-menu": "^0.25.3",
"@material/mwc-ripple": "^0.25.3",
"lit": "^2.1.2",
"@lit-labs/scoped-registry-mixin": "^1.0.1",
"@material/mwc-list": "^0.27.0",
"@material/mwc-menu": "^0.27.0",
"@material/mwc-ripple": "^0.27.0",
"lit": "^2.7.5",
"resize-observer-polyfill": "^1.5.1"
},
"devDependencies": {
Expand Down
5 changes: 5 additions & 0 deletions release_notes/v3.1.5.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
## v3.1.5
[![Downloads](https://img.shields.io/github/downloads/artem-sedykh/mini-humidifier/v3.1.5/total.svg)](https://github.com/artem-sedykh/mini-humidifier/releases/tag/v3.1.5)

### Fixed
- fix: popup menus not working on mobile apps by @regevbr
2 changes: 1 addition & 1 deletion src/components/dropdown-base.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export default class HumidifierDropdownBase extends ScopedRegistryHost(LitElemen
?color=${this.active}>
<ha-icon .icon=${this.icon}></ha-icon>
</ha-icon-button>
<mwc-menu absolute activatable
<mwc-menu fixed activatable
id=${'menu'}
?quick=${true}
.menuCorner=${'END'}
Expand Down
10 changes: 1 addition & 9 deletions src/components/mwc/menu-surface.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { MenuSurfaceBase } from '@material/mwc-menu/mwc-menu-surface-base';
import { styles as menuSurfaceStyles } from '@material/mwc-menu/mwc-menu-surface.css';
import { ScopedRegistryHost } from '@lit-labs/scoped-registry-mixin';
import { css } from 'lit';
import buildElementDefinitions from '../../utils/buildElementDefinitions';

export default class HumidifierMenuSurface extends ScopedRegistryHost(MenuSurfaceBase) {
Expand All @@ -12,13 +11,6 @@ export default class HumidifierMenuSurface extends ScopedRegistryHost(MenuSurfac
}

static get styles() {
return [
menuSurfaceStyles,
css`
.mdc-menu-surface {
position: fixed!important;
}
`,
];
return menuSurfaceStyles;
}
}

0 comments on commit 6ba7849

Please sign in to comment.