Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable full search features with HTTP server #469

Merged

Conversation

eviau-artefactual
Copy link
Contributor

You will need the server to access full search features, such as highlighting the context surrounding keywords you are looking for.

Copy link
Member

@replaceafill replaceafill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this approach, wouldn't you need to explain users that they have to point their browser to http://localhost:8000 or something? And maybe also use the --directory/--d flag to point to the _build/html directory directly?

@eviau-artefactual
Copy link
Contributor Author

I did not know about that flag! Thanks!

@eviau-artefactual
Copy link
Contributor Author

eviau-artefactual commented Jul 16, 2024

The linkcheck test fails because of:

(getting-started/overview/external-tools: line    7) broken    https://www.gnu.org/licenses/agpl-3.0.en.html - HTTPSConnectionPool(host='www.gnu.org', port=443): Max retries exceeded with url: /licenses/agpl-3.0.en.html (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: certificate has expired (_ssl.c:1007)')))

We could review this later on. Adding this as an example of archivematica/Issues#1690

Copy link
Member

@replaceafill replaceafill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

README.md Outdated Show resolved Hide resolved
Co-authored-by: Douglas Cerna <[email protected]>
@eviau-artefactual eviau-artefactual merged commit 4b37049 into artefactual:1.16 Jul 18, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants