Added Error Checking For Empty Granularity List (#1016)

* Added Error Checking * Updated Error Message To Be More Descriptive Co-authored-by: Chris <[email protected]> * Improved Error Message String Co-authored-by: Anish Nyayachavadi <[email protected]> Co-authored-by: Chris <[email protected]> Co-authored-by: Jad Chaar <[email protected]>
arrow-py · Oct 24, 2021 · cc1cbeb · cc1cbeb
1 parent f7a3aa3
commit cc1cbeb
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/arrow/arrow.py b/arrow/arrow.py
@@ -1263,6 +1263,13 @@ def humanize(
                 return locale.describe(granularity, delta, only_distance=only_distance)
 
             else:
+
+                if not granularity:
+                    raise ValueError(
+                        "Empty granularity list provided. "
+                        "Please select one or more from 'second', 'minute', 'hour', 'day', 'week', 'month', 'quarter', 'year'."
+                    )
+
                 timeframes: List[Tuple[TimeFrameLiteral, float]] = []
 
                 def gather_timeframes(_delta: float, _frame: TimeFrameLiteral) -> float:

diff --git a/tests/test_arrow.py b/tests/test_arrow.py
@@ -2286,6 +2286,13 @@ def test_untranslated_granularity(self, mocker):
         with pytest.raises(ValueError):
             arw.humanize(later, granularity="week")
 
+    def test_empty_granularity_list(self):
+        arw = arrow.Arrow(2013, 1, 1, 0, 0, 0)
+        later = arw.shift(seconds=55000)
+
+        with pytest.raises(ValueError):
+            arw.humanize(later, granularity=[])
+
     # Bulgarian is an example of a language that overrides _format_timeframe
     # Applicabale to all locales. Note: Contributors need to make sure
     # that if they override describe or describe_mutli, that delta