POC of Market Based Pricing #4070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* proto * price to scheduler * wip * Update README.md * wip * wip * wip --------- Co-authored-by: Chris Martin <[email protected]> Co-authored-by: Chris Martin <[email protected]>
d80tb7
commented
Dec 2, 2024
| @@ -8,7 +8,7 @@ | |||
| <env name="ARMADA_EXECUTORAPICONNECTION_FORCENOTLS" value="true" /> | |||
| <env name="ARMADA_HTTPPORT" value="8085" /> | |||
| <env name="HOME" value="$USER_HOME$/" /> | |||
| <env name="KUBECONFIG" value="$PROJECT_DIR$/.kube/internal/config" /> | |||
| <env name="KUBECONFIG" value="$PROJECT_DIR$/.kube/external/config" /> | |||
There was a problem hiding this comment.
This is intentional. The run config for the executor is incorrect as internal will attempt to connect via the kind network, which won't work from Goland. external will attempt to connect on loclahost which is correct.
d80tb7
commented
Dec 2, 2024
| @@ -3,6 +3,8 @@ apiVersion: kind.x-k8s.io/v1alpha4 | |||
| name: armada-test | |||
| featureGates: | |||
| "KubeletInUserNamespace": true | |||
| networking: | |||
| apiServerAddress: 0.0.0.0 | |||
There was a problem hiding this comment.
This is intentional. WIthout this the kubeconfig produced by kind will list the address as 0.0.0.0 but a cert that is valid for 127.0.0.1. Settting the apiServerAddress explicitly ensures that kubeconfig alligns with cert.
robertdavidsmith
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof Of Concept Of Market Based Pricing. Main changes are as follows:
ExperimentalPricingInfosection added. This allows aBidPriceto be set.MarketDriven. If this flag is set then the pool will be use price-based scheduling rahter than fair-share-based scheduling.MarketDrivenpools aSpotPricemetric is produced. This will be zero if the pool is less than 95% utilized, otherswise it will be eqaul to the lowest priced job (running or scheduled).