Write simulated events to disk #3111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial simulator filewriter * Adding filewriter * Removing unnecessary print * Addressed PR comments, corrected previous_event_type definition, removed redundant code, changed outputted time field to duration (elapsed_time) * Generalised FileWriter to writer to any io.Writer, cleaned up code * Fixed broken tests, modified flattened armada event to support ephemeral storage, updated definition of previously seen event and current event in output, fixed poor naming * Fixed duplicate event publishing in simulator, improved simulator state, updated writer to reuse array * Refactoring * Fixed typo * Lower case first letter of error description Co-authored-by: Mustafa Ilyas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.