Skip to content

Commit

Permalink
Use minimal instead of minimal-pulsar
Browse files Browse the repository at this point in the history
Signed-off-by: JamesMurkin <[email protected]>
  • Loading branch information
JamesMurkin committed Feb 6, 2024
1 parent 5a02a7c commit da9bcdb
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/python-client.yml
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ jobs:
# Manually create folders to ensure perms are correct.
mkdir -p .kube/internal
mkdir -p .kube/external
go run github.com/magefile/[email protected] -v localdev minimal-pulsar
go run github.com/magefile/[email protected] -v localdev minimal
- name: Install Protoc
uses: arduino/setup-protoc@v2
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ jobs:
cache-tools: true

- name: Setup Integration Tests
run: go run github.com/magefile/[email protected] -v localdev minimal-pulsar
run: go run github.com/magefile/[email protected] -v localdev minimal

- name: Run Integration Tests
run: go run github.com/magefile/[email protected] -v testsuite
Expand Down
8 changes: 4 additions & 4 deletions docs/developer.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ This document is intended for developers who want to contribute to the project.
Want to quickly get Armada running and test it? Install the [Pre-requisites](#pre-requisites) and then run:

```bash
mage localdev minimal-pulsar testsuite
mage localdev minimal testsuite
```

To get the UI running, run:
Expand Down Expand Up @@ -76,10 +76,10 @@ LocalDev provides a reliable and extendable way to install Armada as a developer
It has the following options to customize further steps:

* `mage localdev full` - Runs all components of Armada, including the Lookout UI.
* `mage localdev minimal-pulsar` - Runs only the core components of Armada (such as the API server and an executor).
* `mage localdev minimal` - Runs only the core components of Armada (such as the API server and an executor).
* `mage localdev no-build` - Skips the build step; set `ARMADA_IMAGE` and `ARMADA_TAG` to choose the Docker image to use.

`mage localdev minimal-pulsar` is what is used to test the CI pipeline, and is the recommended way to test changes to the core components of Armada.
`mage localdev minimal` is what is used to test the CI pipeline, and is the recommended way to test changes to the core components of Armada.

## Debug error saying that the (port 6443 is already in use) after running mage localdev full

Expand Down Expand Up @@ -150,7 +150,7 @@ mage LocalDevStop
And then run

```bash
mage LocalDev minimal-pulsar
mage LocalDev minimal
```

Ensure your local dev environment is completely torn down when switching between pulsar backed and legacy
Expand Down

0 comments on commit da9bcdb

Please sign in to comment.