internal/controller: override desired url if it is provided in the custom config #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datdao
force-pushed
the
d/custom-atlas-config
branch
2 times, most recently
from
f96008a to
604966a
Compare
datdao
force-pushed
the
d/custom-atlas-config
branch
from
604966a to
69ec823
Compare
datdao
requested review from
giautm and
rotemtam
and removed request for
giautm
giautm
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the target URL argument and its constraint when running Atlas commands in declarative flow. Instead, it relies on the
schema.srcinatlas.hcl, which is generated by the Operator. With this change, users can use custom configurations to set up more advanced cases, such ascomposite_schema,external_schema, and more.