Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atlas/schema: added concurrent_index support #106

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Conversation

giautm
Copy link
Member

@giautm giautm commented Nov 27, 2023

No description provided.

@giautm giautm force-pushed the g/conurrent_index branch 4 times, most recently from 52ed254 to 91d8f28 Compare November 28, 2023 11:54
@rotemtam
Copy link
Member

@giautm any news on this?

@giautm
Copy link
Member Author

giautm commented Dec 14, 2023

@giautm any news on this?

Honestly, I haven't found an easy way to write a test for this with the operator yet. That's remain of pending

@giautm giautm marked this pull request as ready for review December 31, 2023 18:33
@giautm giautm requested a review from datdao December 31, 2023 18:34
@giautm giautm force-pushed the g/conurrent_index branch 6 times, most recently from fde341c to c8b3260 Compare January 15, 2024 11:37
@rotemtam
Copy link
Member

Perhaps you can make assertions about the created atlas.hcl configuration, after all you don't need to test atlas itself

@giautm giautm force-pushed the g/conurrent_index branch from 72febbf to a26fc08 Compare March 19, 2024 06:25
@giautm giautm requested a review from rotemtam March 19, 2024 06:27
@giautm giautm merged commit 1e817fd into master Mar 19, 2024
5 checks passed
@giautm giautm deleted the g/conurrent_index branch March 19, 2024 06:52
Copy link
Member

@rotemtam rotemtam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test please !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants