Skip to content

Commit

Permalink
Merge pull request riscv#11 from rpsene/main
Browse files Browse the repository at this point in the history
Updates to fix the build issues
  • Loading branch information
wmat authored Apr 11, 2023
2 parents f520cd3 + 0a5e626 commit 80351ee
Show file tree
Hide file tree
Showing 8 changed files with 76 additions and 75 deletions.
40 changes: 17 additions & 23 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,26 +1,23 @@
# Contribution Guidelines

As an open-source project, we welcome and encourage the community to submit patches directly to the project. In our collaborative open source environment, standards and methods for submitting changes help reduce the chaos that can result from an active development community.
As an open-source project, we appreciate and encourage community members to submit patches directly to the project. To maintain a well-organized development environment, we have established standards and methods for submitting changes. This document outlines the process for submitting patches to the project, ensuring that your contribution is swiftly incorporated into the codebase.

This document explains how to submit patches to the project so your patch will be accepted quickly in the codebase.
# Licensing

## Licensing
Licensing is crucial for open-source projects, as it guarantees that the software remains available under the conditions specified by the author.

Licensing is very important to open source projects. It helps ensure the software continues to be available under the terms that the author desired.
This project employs the Creative Commons Attribution 4.0 International license, which can be found in the LICENSE file within the project's repository.

This project uses the Creative Commons Attribution 4.0 International license, as found in the [LICENSE](https://github.com/riscv/docs-spec-template/blob/main/LICENSE) file in the project's repo.
Licensing defines the rights granted to you as an author by the copyright holder. It is essential for contributors to fully understand and accept these licensing rights. In some cases, the copyright holder may not be the contributor, such as when the contributor is working on behalf of a company.

A license tells you what rights you have as an author, as provided by the copyright holder. It is important that the contributor fully understands the licensing rights and agrees to them. Sometimes the copyright holder isn't the contributor, such as when the contributor is doing work on behalf of a company.
# Developer Certificate of Origin (DCO)
To uphold licensing criteria and demonstrate good faith, this project mandates adherence to the Developer Certificate of Origin (DCO) process.

## Developer Certification of Origin (DCO)
The DCO is an attestation appended to every contribution from each author. In the commit message of the contribution (explained in greater detail later in this document), the author adds a Signed-off-by statement, thereby accepting the DCO.

To make a good faith effort to ensure licensing criteria are met, this project requires the Developer Certificate of Origin (DCO) process to be followed.
When an author submits a patch, they affirm that they possess the right to submit the patch under the designated license. The DCO agreement is displayed below and at https://developercertificate.org.

The DCO is an attestation attached to every contribution made by every author. In the commit message of the contribution (described more fully later in this document), the author simply adds a ``Signed-off-by`` statement and thereby agrees to the DCO.

When an author submits a patch, it is a commitment that the contributor has the right to submit the patch per the license. The DCO agreement is shown below and at https://developercertificate.org.

```
Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:
Expand All @@ -38,27 +35,24 @@ By making a contribution to this project, I certify that:
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
person who certified (a), (b), or (c), and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
```

### DCO Sign-Off Methods

The DCO requires that a sign-off message, in the following format, appears on each commit in the pull request:

`Signed-off-by: Stephano Cetola <[email protected]>`
# DCO Sign-Off Methods
The DCO necessitates the inclusion of a sign-off message in the following format for each commit within the pull request:

You are required to use your real name in the sign-off message.
Signed-off-by: Stephano Cetola <[email protected]>

The DCO text can either be manually added to your commit body, or you can add either ``-s`` or ``--signoff`` to your usual Git commit commands. If you forget to add the sign-off you can also amend a previous commit with the sign-off by running ``git commit --amend -s``. If you've pushed your changes to GitHub already you'll need to force push your branch after this with ``git push -f``.
Please use your real name in the sign-off message.

You can manually add the DCO text to your commit body or include either -s or --signoff in your standard Git commit commands. If you forget to incorporate the sign-off, you can also amend a previous commit with the sign-off by executing git commit --amend -s. If you have already pushed your changes to GitHub, you will need to force push your branch afterward using git push -f.

**Note:**
Note:

The name and email address of the account you use to submit your PR must match the name and email address on the ``Signed-off-by`` line in your commit message.
Ensure that the name and email address associated with your GitHub account match the name and email address in the Signed-off-by line of your commit message.
24 changes: 12 additions & 12 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
HEADER_SOURCE := header.adoc
PDF_RESULT := example-spec.pdf

ASCIIDOCTOR_PDF := asciidoctor-pdf
OPTIONS := --trace -a compress \
--attribute=mathematical-format=svg \
--attribute=pdf-fontsdir=docs-resources/fonts \
--attribute=pdf-style=docs-resources/themes/riscv-pdf.yml \
--failure-level=ERROR
REQUIRES := --require=asciidoctor-bibtex \
--require=asciidoctor-diagram \
--require=asciidoctor-mathematical

all: build

build:

@echo "Building asciidoc"
asciidoctor-pdf \
--attribute=mathematical-format=svg \
--attribute=pdf-fontsdir=docs-resources/fonts \
--attribute=pdf-style=docs-resources/themes/riscv-pdf.yml \
--failure-level=ERROR \
--require=asciidoctor-bibtex \
--require=asciidoctor-diagram \
--require=asciidoctor-mathematical \
--out-file=$(PDF_RESULT) \
$(HEADER_SOURCE)
$(ASCIIDOCTOR_PDF) $(OPTIONS) $(REQUIRES) --out-file=$(PDF_RESULT) $(HEADER_SOURCE)

clean:
rm $(PDF_RESULT)
rm $(PDF_RESULT)
12 changes: 11 additions & 1 deletion dependencies/apt_packages.txt
Original file line number Diff line number Diff line change
@@ -1,21 +1,31 @@
bison
build-essential
python3-pip
cmake
curl
flex
fonts-lyx
git
graphviz
# For wavedrom
default-jre
libcairo2-dev
libffi-dev
libgdk-pixbuf2.0-dev
libpango1.0-dev
libxml2-dev
libglib2.0-dev
make
pkg-config
ruby
ruby-dev
libgif-dev
libwebp-dev
libzstd-dev
ruby-full
gem
npm
texlive-latex-base
texlive-fonts-recommended
texlive-fonts-extra
texlive-latex-extra
texlive-science
7 changes: 4 additions & 3 deletions dependencies/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
{
"name": "local",
"version": "0.0.1",
"dependencies": {
"bytefield-svg": "^1.8.0",
"wavedrom-cli": "^2.6.8"
}
},
"name": "local",
"version": "0.0.1"
}
52 changes: 24 additions & 28 deletions example.bib
Original file line number Diff line number Diff line change
Expand Up @@ -2,39 +2,35 @@ @inproceedings{riscI-isca1981
title = {{RISC I}: {A} Reduced Instruction Set {VLSI} Computer},
author = {David A. Patterson and Carlo H. S\'{e}quin},
booktitle = {ISCA},
location = {Minneapolis, Minnesota, USA},
location = {Minneapolis, Minnesota, USA},
pages = {443-458},
year = {1981}
}

@InProceedings{Katevenis:1983,
author = {Katevenis, Manolis G.H. and Sherburne,Jr., Robert W. and Patterson, David A. and S{\'e}quin, Carlo H.},
title = {The {RISC II} micro-architecture},
@inproceedings{Katevenis:1983,
author = {Manolis G.H. Katevenis and Robert W. Sherburne Jr. and David A. Patterson and Carlo H. S\'{e}quin},
title = {The {RISC II} micro-architecture},
booktitle = {Proceedings VLSI 83 Conference},
year = 1983,
month = {August}}
year = {1983},
month = {August}
}

@inproceedings{Ungar:1984,
author = {David Ungar and Ricki Blau and Peter Foley and Dain Samples
and David Patterson},
title = {Architecture of {SOAR}: {Smalltalk} on a {RISC}},
booktitle = {ISCA},
address = {Ann Arbor, MI},
year = {1984},
pages = {188--197}
}
author = {David Ungar and Ricki Blau and Peter Foley and Dain Samples and David Patterson},
title = {Architecture of {SOAR}: {Smalltalk} on a {RISC}},
booktitle = {ISCA},
address = {Ann Arbor, MI},
year = {1984},
pages = {188-197}
}

@Article{spur-jsscc1989,
author = {David D. Lee and Shing I. Kong and Mark D. Hill and
George S. Taylor and David A. Hodges and Randy
H. Katz and David A. Patterson},
title = {A {VLSI} Chip Set for a Multiprocessor
Workstation--{Part I}: An {RISC} Microprocessor with
Coprocessor Interface and Support for Symbolic
Processing},
journal = {IEEE JSSC},
year = 1989,
volume = 24,
number = 6,
pages = {1688--1698},
month = {December}}
@article{spur-jsscc1989,
author = {David D. Lee and Shing I. Kong and Mark D. Hill and George S. Taylor and David A. Hodges and Randy H. Katz and David A. Patterson},
title = {A {VLSI} Chip Set for a Multiprocessor Workstation--{Part I}: An {RISC} Microprocessor with Coprocessor Interface and Support for Symbolic Processing},
journal = {IEEE JSSC},
year = {1989},
volume = {24},
number = {6},
pages = {1688-1698},
month = {December}
}
15 changes: 8 additions & 7 deletions header.adoc
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
= RISC-V Example Specification Document (Zexmpl)
Author 1; Author 2; RISC-V Task Group

[[header]]
:description: RISC-V Example Specification Document (Zexmpl)
:company: RISC-V.org
:revdate: 1/2022
:revdate: 1/2023
:revnumber: 1.0
:revremark: This document is in development. Assume everything can change. See http://riscv.org/spec-state for details.
:url-riscv: http://riscv.org
Expand All @@ -10,7 +13,7 @@
:colophon:
:appendix-caption: Appendix
:imagesdir: images
:title-logo-image: image:risc-v_logo.svg[pdfwidth=3.25in,align=center]
:title-logo-image: image:risc-v_logo.png[pdfwidth=3.25in,align=center]
// Settings:
:experimental:
:reproducible:
Expand All @@ -36,9 +39,6 @@ endif::[]
:footnote:
:xrefstyle: short

= RISC-V Example Specification Document (Zexmpl)
Author 1; Author 2; RISC-V Task Group

// Preamble
[WARNING]
.This document is in the link:http://riscv.org/spec-state[Development state]
Expand All @@ -62,6 +62,7 @@ include::contributors.adoc[]

include::intro.adoc[]
include::chapter2.adoc[]
//the index must precede the bibliography

// The index must precede the bibliography
include::index.adoc[]
include::bibliography.adoc[]
include::bibliography.adoc[]
Binary file added images/risc-v_logo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 0 additions & 1 deletion images/risc-v_logo.svg

This file was deleted.

0 comments on commit 80351ee

Please sign in to comment.