Add NISAR product support #390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfattahi
reviewed
Mar 20, 2024
tools/ARIAtools/ARIAProduct.py
Outdated
Comment on lines
649
to
653
| rdrmetadata_dict['wavelength'] = 0.24 | ||
| rdrmetadata_dict['centerFrequency'] = 1.2699997500604727e+09 | ||
| rdrmetadata_dict['slantRangeSpacing'] = 4.461197291666666 | ||
| rdrmetadata_dict['slantRangeStart'] = 727415.98682514 | ||
| rdrmetadata_dict['slantRangeEnd'] = 791384.81843777 |
There was a problem hiding this comment.
Any reason to hardcode any of these parameters? They all exist in the NISAR GUNW products. The wavelength and center frequency may be different for different modes and should not be assumed constant for all NISAR L-SAR modes.
There was a problem hiding this comment.
@hfattahi yes, those hardcoded values were a vestige. I went ahead and accessed the appropriate parameters directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.