Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: document theme switch imports #540

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

kaf-lamed-beyt
Copy link
Contributor

#304

How does this look @argyleink?

image

Copy link

stackblitz bot commented Jan 1, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Owner

@argyleink argyleink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great so far! thanks a bunch ❤️ I can see the effort put in.

I had enough edits that I made a PR to your fork. Mind accepting those, then this branch/PR will update and we can see if there are last minute edits to make?

@kaf-lamed-beyt
Copy link
Contributor Author

oh alright. thanks for the feedback. I'll take a look at the PR now

@@ -138,7 +138,7 @@
border-radius: var(--radius-2);
}

:where(textarea) {
:where(textarea) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a strange commit? can you remove it so the PR is just on the index.html file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh! That must have been from prettier. I must have pressed ctrl + shift + i to format the file manually. My bad.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at it now... I don't know how to actually update it without creating a commit in that file.

image

Although I pulled from my remote now and I can see that index.html has untracked changes. Perhaps pushing that change may update normalize.src.css?

image

What do you think?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll squash this work in, so the history isn't that big of a deal. if you just push an update to the branch that removes this commit, that should be good enough. i'm not a stickler about the file history, and yeah, we'll be squashing so shouldnt be an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants