-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: document theme switch imports #540
base: main
Are you sure you want to change the base?
Conversation
Run & review this pull request in StackBlitz Codeflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great so far! thanks a bunch ❤️ I can see the effort put in.
I had enough edits that I made a PR to your fork. Mind accepting those, then this branch/PR will update and we can see if there are last minute edits to make?
oh alright. thanks for the feedback. I'll take a look at the PR now |
a PR for your PR!
@@ -138,7 +138,7 @@ | |||
border-radius: var(--radius-2); | |||
} | |||
|
|||
:where(textarea) { | |||
:where(textarea) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a strange commit? can you remove it so the PR is just on the index.html file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huh! That must have been from prettier. I must have pressed ctrl + shift + i
to format the file manually. My bad.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'll squash this work in, so the history isn't that big of a deal. if you just push an update to the branch that removes this commit, that should be good enough. i'm not a stickler about the file history, and yeah, we'll be squashing so shouldnt be an issue.
#304
How does this look @argyleink?