fix(argo-cd): Fix required cluster credentials name #3111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atgane
requested review from
mbevc1,
mkilchhofer,
yu-croco,
jmeridth,
pdrastil and
tico24
as code owners
atgane
changed the title
mkilchhofer
reviewed
Jan 23, 2025
| @@ -22,7 +22,7 @@ stringData: | |||
| {{- if $cluster_value.shard }} | |||
| shard: {{ $cluster_value.shard | quote }} | |||
| {{- end }} | |||
| name: {{ required "A valid .Values.configs.clusterCredentials.CLUSTERNAME.name entry is required!" $cluster_key }} | |||
| name: {{ default $cluster_key $cluster_value.name }} | |||
There was a problem hiding this comment.
Suggested change
| name: {{ default $cluster_key $cluster_value.name }} | |
| name: {{ $cluster_key }} |
The simplest solution I see is to drop the required function
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #3110
Checklist: