Incorrect validation of CLUSTERNAME.name in clusterCredentials

[atgane]

Is your feature request related to a problem?

argo-helm/charts/argo-cd/templates/argocd-configs/cluster-secrets.yaml

Line 25 in 9946d3d

name: {{ required "A valid .Values.configs.clusterCredentials.CLUSTERNAME.name entry is required!" $cluster_key }}

There is something wrong with the way the required function is used in that line. It looks like what the function means is to check CLUSTERNAME.name in clusterCredentials, but this value always contains $cluster_key, so it doesn't throw an error in required.

Related helm chart

argo-cd

Describe the solution you'd like

I would suggest using $cluster_key as the default value and writing $cluster_value.name without validation.

like this:

  name: {{ default $cluster_key $cluster_value.name }}

Describe alternatives you've considered

No response

Additional context

No response