Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: gcc improvements #1750

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Conversation

jcm93
Copy link
Contributor

@jcm93 jcm93 commented Jan 5, 2025

Linking was failing under MinGW gcc because of a link order issue between libares and mingw32. Establishing a direct link relationship between desktop-ui and mingw32 means that our WinMain definition will not be discarded by ld before it's needed.

We also here add a Linux gcc runner and a Windows gcc runner; these do not upload artifacts, but will allow us to detect build failures on CI.

At the moment, gcc support in general under CMake will still rougher edges than clang or MSVC support, but it is intended that building with gcc and ld should always at least work, even if clang remains recommended and achieves superior performance.

This PR also adds a warning in the N64 core to acknowledge #1737 until that issue can be fixed.

@LukeUsher LukeUsher merged commit a960aee into ares-emulator:master Jan 5, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants