Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linking was failing under MinGW gcc because of a link order issue between
libares
andmingw32
. Establishing a direct link relationship betweendesktop-ui
andmingw32
means that ourWinMain
definition will not be discarded byld
before it's needed.We also here add a Linux gcc runner and a Windows gcc runner; these do not upload artifacts, but will allow us to detect build failures on CI.
At the moment, gcc support in general under CMake will still rougher edges than clang or MSVC support, but it is intended that building with
gcc
andld
should always at least work, even ifclang
remains recommended and achieves superior performance.This PR also adds a warning in the N64 core to acknowledge #1737 until that issue can be fixed.