ColecoVision - Added "Xin1" and "MegaCart" mapper #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added K188in1 Mapper Changed "msx.cpp" to "zemina" as lots of MSX ports dont use the mapper and its only used by ports by Zemina.
Added "Xin1" mapper for the ColecoVision, this mapper supports: - 31-in-1 (v1.1) ( 2013 ) - 63-in-1 (v1.0) ( 2013/0 1) Both carts are by "Buzz and ZX-81".
Added "Xin1" mapper for the ColecoVision, this mapper automaticly triggers for any rom over 32k that isnt known to be another mapper (like the "xin1" mapper i added a hour or two ago) it all should be well with all homebrew games that requite the MegaCart hardware. If anyone knows of any other ColecoVision carts like these let me know and I'll try to add them.
Kalixtan
changed the title
LukeUsher
requested changes
Dec 7, 2023
ares/cv/cartridge/board/coleco.cpp
Outdated
| } | ||
|
|
||
| auto write(n16 address, n8 data) -> void override { | ||
| return; |
ares/cv/cartridge/board/megacart.cpp
Outdated
| auto unload() -> void override {} | ||
|
|
||
| auto read(n16 address) -> n8 override { | ||
| if (address >= 0x7FC0){ |
There was a problem hiding this comment.
nit: indentation, again
nit: hex constants should be lowercase
ares/cv/cartridge/board/megacart.cpp
Outdated
| bank = address & (bankcount - 1); | ||
| } | ||
| if (address >= 0x4000){ | ||
| return rom.read( (bank << 14) + (address - 0x4000) ); |
There was a problem hiding this comment.
nit: weird spacing around brackets
ares/cv/cartridge/board/megacart.cpp
Outdated
| } | ||
|
|
||
| auto write(n16 address, n8 data) -> void override { | ||
| return; |
ares/cv/cartridge/board/megacart.cpp
Outdated
| } | ||
|
|
||
| auto power() -> void override { | ||
| bankcount = rom.size() >> 14; |
ares/cv/cartridge/board/xin1.cpp
Outdated
| auto unload() -> void override {} | ||
|
|
||
| auto read(n16 address) -> n8 override { | ||
| if (address >= 0x7fc0){ |
ares/cv/cartridge/board/xin1.cpp
Outdated
| } | ||
|
|
||
| auto write(n16 address, n8 data) -> void override { | ||
| return; |
ares/cv/cartridge/board/xin1.cpp
Outdated
| } | ||
|
|
||
| auto power() -> void override { | ||
| bankcount = rom.size() / 0x8000; |
invertego
pushed a commit
to invertego/ares
that referenced
this pull request
Dec 13, 2023
Added "Xin1" mapper for the ColecoVision, this mapper supports: - 31-in-1 (v1.1) ( 2013 ) - 63-in-1 (v1.0) ( 2013/0 1) Both carts are by "Buzz and ZX-81", and i tested all games for both multis and they all at least boot perfectly fine And the "MegaCart" mapper, this mapper automaticly triggers for any rom over 32k that isnt known to be another mapper (like the "xin1" mapper). it all should be well with all homebrew games that requite the MegaCart hardware. If anyone knows of any other ColecoVision carts like these let me know and I'll try to add them. --------- Co-authored-by: Luke Usher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added "Xin1" mapper for the ColecoVision, this mapper supports:
Both carts are by "Buzz and ZX-81", and i tested all games for both multis and they all at least boot perfectly fine
And the "MegaCart" mapper, this mapper automaticly triggers for any rom over 32k that isnt known to be another mapper (like the "xin1" mapper).
it all should be well with all homebrew games that requite the MegaCart hardware.
If anyone knows of any other ColecoVision carts like these let me know and I'll try to add them.