Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight data classes #33

Merged
merged 2 commits into from
Apr 15, 2020
Merged

Highlight data classes #33

merged 2 commits into from
Apr 15, 2020

Conversation

aremazeilles
Copy link
Owner

Fix #6

I restructured the file to highlight the data types, as commented in #6.
I added a 4th class, for raw data file.

Some additional points to mention:

  • the bipedal system section is unclear to me. I gathered all subsections related to it, and it does not seem to be completely consistent. Would need revision. I think we have several issues related to that aspect already: urdf use for humans #5, Model specification #20, 4.8. Humanoid anthropometric measures file #21
  • I simplified the testbed naming aspects. For me, a protocol involves one setting file, whatever is the equipment involved. So there is no need reminding the protocol name in the testbed name.
  • If a testbed can change along time (like changing the slope), I suggest adding a number to identify it. We should also refer to that number in other recorded file. Other issue?

@aremazeilles aremazeilles mentioned this pull request Apr 8, 2020
Closed
alfonsotecnalia
alfonsotecnalia reviewed Apr 14, 2020
View reviewed changes
data_format.adoc Outdated
This file shall contain the dimensions and inertial properties of each segment of the worn robot with respect to the reference system of the human body segment connected to it.
This is needed to enable dynamic simulators to model the human-WR system.

**name of the file**: `wr_N_config_M_segments`, where `N` is the WR number and `M` is the configuration number (for resizable robots this could be useful).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name of the file is before file format in the other types

alfonsotecnalia
alfonsotecnalia reviewed Apr 14, 2020
View reviewed changes
data_format.adoc Outdated Show resolved Hide resolved
@aremazeilles
Copy link
Owner Author

Ready to merge @alfonsotecnalia ?

@alfonsotecnalia alfonsotecnalia merged commit 3c85bae into master Apr 15, 2020
@alfonsotecnalia
Copy link
Collaborator

Done!

@alfonsotecnalia alfonsotecnalia deleted the file_class branch April 15, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfonsotecnalia alfonsotecnalia alfonsotecnalia left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Anthropomorphic, humanoid and testbed file class
2 participants
@aremazeilles @alfonsotecnalia