Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(json-schema): make array elements nonnullable (#6630) #6633

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/@graphql-mesh_compose-cli-6630-dependencies.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@graphql-mesh/compose-cli": patch
---
dependencies updates:
- Updated dependency [`@graphql-tools/utils@^10.1.0` ↗︎](https://www.npmjs.com/package/@graphql-tools/utils/v/10.1.0) (from `^10.0.8`, in `dependencies`)
5 changes: 5 additions & 0 deletions .changeset/@graphql-mesh_compose-cli-6633-dependencies.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@graphql-mesh/compose-cli": patch
---
dependencies updates:
- Updated dependency [`@graphql-tools/utils@^10.1.0` ↗︎](https://www.npmjs.com/package/@graphql-tools/utils/v/10.1.0) (from `^10.0.8`, in `dependencies`)
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@graphql-mesh/fusion-composition": patch
---
dependencies updates:
- Added dependency [`pluralize@^8.0.0` ↗︎](https://www.npmjs.com/package/pluralize/v/8.0.0) (to `dependencies`)
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@graphql-mesh/plugin-operation-headers": patch
---
dependencies updates:
- Updated dependency [`@graphql-mesh/serve-runtime@^0.2.0` ↗︎](https://www.npmjs.com/package/@graphql-mesh/serve-runtime/v/0.2.0) (from `^0.1.1`, in `peerDependencies`)
- Updated dependency [`@graphql-mesh/types@^0.97.0` ↗︎](https://www.npmjs.com/package/@graphql-mesh/types/v/0.97.0) (from `^0.96.6`, in `peerDependencies`)
- Updated dependency [`@graphql-mesh/utils@^0.97.0` ↗︎](https://www.npmjs.com/package/@graphql-mesh/utils/v/0.97.0) (from `^0.96.6`, in `peerDependencies`)
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@graphql-mesh/plugin-operation-headers": patch
---
dependencies updates:
- Updated dependency [`@graphql-mesh/serve-runtime@^0.2.0` ↗︎](https://www.npmjs.com/package/@graphql-mesh/serve-runtime/v/0.2.0) (from `^0.1.1`, in `peerDependencies`)
- Updated dependency [`@graphql-mesh/types@^0.97.0` ↗︎](https://www.npmjs.com/package/@graphql-mesh/types/v/0.97.0) (from `^0.96.6`, in `peerDependencies`)
- Updated dependency [`@graphql-mesh/utils@^0.97.0` ↗︎](https://www.npmjs.com/package/@graphql-mesh/utils/v/0.97.0) (from `^0.96.6`, in `peerDependencies`)
6 changes: 6 additions & 0 deletions .changeset/smart-coats-smash.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@omnigraph/json-schema": patch
---

Array elements should be nonnullable
NOTE: The output might be breaking in terms of GraphQL but it is a fix actually to represent JSON schemas correctly in GraphQL
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ directive @transport(headers: ObjMap, kind: String, location: String, queryParam
"""Desc Api Population"""
type ApiPopulation {
_response: ResponseMetadata
records: [Result]
records: [Result!]
}

""""""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ type User {
jobTitle: String
companyId: String
birthDate: Date
foos: [Foo]
foos: [Foo!]
company: Company
}

Expand Down
6,276 changes: 3,138 additions & 3,138 deletions examples/json-schema-fhir/tests/__snapshots__/fhir.test.js.snap

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ directive @transport(subgraph: String, kind: String, location: String, headers:
directive @live on QUERY

type Query {
todos: [query_todos_items] @httpOperation(subgraph: "Example", path: "/todos", httpMethod: GET)
todos: [query_todos_items!] @httpOperation(subgraph: "Example", path: "/todos", httpMethod: GET)
}

type query_todos_items {
Expand Down

Large diffs are not rendered by default.

Loading
Loading