fix 1267: early return in runForMultiple if an empty array is passed

archtechx · Jan 8, 2025 · c30fb5d · c30fb5d
1 parent f955b38
commit c30fb5d
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/Tenancy.php b/src/Tenancy.php
@@ -204,8 +204,10 @@ public function runForMultiple($tenants, Closure $callback): void
         // Wrap string in array
         $tenants = is_string($tenants) ? [$tenants] : $tenants;
 
-        // Use all tenants if $tenants is falsy
-        $tenants = $tenants ?: $this->model()->cursor(); // todo@phpstan phpstan thinks this isn't needed, but tests fail without it
+        // If $tenants is falsy by this point (e.g. an empty array) there's no work to be done
+        if (! $tenants) {
+            return;
+        }
 
         $originalTenant = $this->tenant;