-
-
Notifications
You must be signed in to change notification settings - Fork 445
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[4.x] Improve RootUrl and UrlGenerator bootstrappers (#1294)
* Make RootUrlBootstrapper run ONLY in CLI by default (add $rootUrlOverrideInTests), work with resolved UrlGenerator * Make resolving 'url' return a pre-created generator instance instead of creating it on every app('url') call * Take care of doubling tenant keys in TenancyUrlGenerator, add regression test for using UrlGenerator and RootUrl bootstrappers together * Fix code style (php-cs-fixer) * refactor RootUrlBootstrapper * add docblock * clarify docblock * simplify test: use concrete values instead of overly dynamic code * Fix bootstrapper order in test, add url('/') assertion * Use $this->app instead of app() * Improve TenancyUrlGenerator and RootUrlBootstrapperTest clarity * Revert attempt to maintain compatibility between the two bootstrappers * Delete bootstrapper combining test * Fix code style (php-cs-fixer) --------- Co-authored-by: lukinovec <[email protected]> Co-authored-by: PHP CS Fixer <[email protected]>
- Loading branch information
1 parent
8f958d5
commit 5d3b3d3
Showing
3 changed files
with
45 additions
and
25 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters