Adding stream support to Dynalite #70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mcwhittemore thanks for the PR! I gather you haven't seen #67 😸 |
|
Oh man. Sorry. I looked for a PR a few weeks ago. Nice to see this is moving. |
|
No worries – now that the holidays are over I should have some time to look at how best to achieve this – so perhaps things can be pulled together from both your work and that of @kiril-pirozenko-home24 |
|
@kiril-pirozenko-home24's is much closer to be done it looks like. Though, mine was designed around hooking up triggers and I'm not 100% sure how to do that with what's in #67 right now. I'll close this and make some comments over there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mhart - I need stream support for some tests I'm writing. Is this something you are interested in adding to dynalite? I see its mentioned in the TODOs.
Todos for this PR:
/cc @rclark @scothis