Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Aeip/23_dapp_secured_session #829

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

✨ Aeip/23_dapp_secured_session #829

wants to merge 4 commits into from

Conversation

Chralu
Copy link
Collaborator

@Chralu Chralu commented Oct 2, 2023 •
edited
Loading

Description

Implementation of Dapp communication securisation.

See AEIP-23 for details.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactorization

Material used:

Please delete options that are not relevant.

  • iOS (Smartphone/Tablet)
  • Android (Smartphone/Tablet)
  • Browser
  • Linux
  • Windows
  • iOS (Mac)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Patrol

Please list here the tests created in Patrol for this pull request.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Useful info for the reviewer:

@Chralu Chralu force-pushed the aeip/23_dapp_secured_session branch 2 times, most recently from 20b7b51 to 8b5d137 Compare October 15, 2023 17:12
@Chralu Chralu force-pushed the aeip/23_dapp_secured_session branch 3 times, most recently from 1c620d3 to 76a455b Compare October 27, 2023 08:41
@Chralu Chralu marked this pull request as ready for review October 27, 2023 08:52
@Chralu Chralu requested a review from redDwarf03 October 27, 2023 08:53
@Chralu Chralu changed the title ✨ WIP - open session RPC commands handlers ✨ DApp secured session Nov 7, 2023
@Chralu Chralu changed the title ✨ DApp secured session ✨ Aeip/23_dapp_secured_session Nov 7, 2023
@Chralu Chralu force-pushed the aeip/23_dapp_secured_session branch from 6dd837b to 6fc4b2f Compare November 7, 2023 13:39
@Chralu Chralu force-pushed the aeip/23_dapp_secured_session branch 2 times, most recently from c3c7b53 to b0c1b91 Compare December 19, 2023 19:12
@redDwarf03
Copy link
Member

  • migrate the new OpenSessionChallengeHandler, which uses Sheets on an entire screen
  • internationalize the ValidateSessionForm screen

@redDwarf03 redDwarf03 force-pushed the aeip/23_dapp_secured_session branch 2 times, most recently from 41ff8c5 to f313c8a Compare January 16, 2024 14:45
Chralu and others added 4 commits February 21, 2024 17:31
@Chralu @redDwarf03
✨ open session RPC commands handlers
015eb13 
🐛 Fix RPC errors handling.
✨ add openSessionChallenge consumer.
✨ Rename CommandDispatcher to CommandBus
Fixes CommandBus tests.
✨ Handles Open session challenge request.
♻️ Renamed API RPC command handlers into CommandReceiver.
✨ use new secured DApp communications.
✨ Handle unsubscription on secured connections.
🐛 Fix deeplink session challenge encoding.
📌 Use AWC from git.
🐛 Fix theme usage.
⚰️ Remove commented code
@redDwarf03
Fix archethic_wallet_client dependency
f17c912
@redDwarf03
🐛 Fix sheet issue
2d4289b
@redDwarf03
fix
6382cdf
@redDwarf03 redDwarf03 force-pushed the aeip/23_dapp_secured_session branch from f313c8a to 6382cdf Compare February 21, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redDwarf03 redDwarf03 Awaiting requested review from redDwarf03

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Chralu @redDwarf03