Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ♻️ Uniformise setPassword and setYubikey widgets #1048

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

redDwarf03
Copy link
Member

Description

Following updates on authentification, this issue should be ok.
I just rename some things and add dispose methods

Fixes #658

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Refactorization

Material used:

Please delete options that are not relevant.

  • iOS (Mac)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Useful info for the reviewer:

@redDwarf03 redDwarf03 linked an issue Jul 23, 2024 that may be closed by this pull request
@redDwarf03 redDwarf03 requested a review from Chralu July 23, 2024 21:25
@Chralu Chralu merged commit 2a5eed5 into dev Jul 24, 2024
3 checks passed
@Chralu Chralu deleted the 658-standardize-set_yubikeydart-and-set_passworddart branch July 24, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize set_yubikey.dart and set_password.dart
2 participants