Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add loongarch64 support #11

Merged
merged 1 commit into from
Jan 18, 2025
Merged

feat: add loongarch64 support #11

merged 1 commit into from
Jan 18, 2025

Conversation

yfblock
Copy link
Contributor

@yfblock yfblock commented Jan 13, 2025

No description provided.

@yfblock yfblock force-pushed the main branch 2 times, most recently from 27825e7 to 6b5444d Compare January 14, 2025 08:08
@yfblock
Copy link
Contributor Author

yfblock commented Jan 14, 2025

Done, fixed missing doc error

@yfblock yfblock force-pushed the main branch 3 times, most recently from d59df8d to 64f29d0 Compare January 17, 2025 05:08
@yfblock yfblock force-pushed the main branch 3 times, most recently from 7701b3d to aa50655 Compare January 17, 2025 07:39
@yfblock
Copy link
Contributor Author

yfblock commented Jan 17, 2025

done

@yfblock yfblock force-pushed the main branch 3 times, most recently from 80cd334 to 14a51c6 Compare January 17, 2025 14:57
equation314
equation314 reviewed Jan 17, 2025
View reviewed changes
Copy link
Member

@equation314 equation314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the crate README files.

page_table_entry/src/arch/loongarch64.rs Outdated Show resolved Hide resolved
page_table_entry/src/arch/loongarch64.rs Outdated Show resolved Hide resolved
page_table_entry/src/arch/loongarch64.rs Outdated Show resolved Hide resolved
@yfblock
Copy link
Contributor Author

yfblock commented Jan 17, 2025

Need to update crate version?

@equation314
Copy link
Member

equation314 commented Jan 17, 2025 •
edited
Loading

Need to update crate version?

I'll do that.

We also need to bump 0.4.x versions for 2021 edition.

@yfblock
Copy link
Contributor Author

yfblock commented Jan 17, 2025

Done

equation314
equation314 reviewed Jan 17, 2025
View reviewed changes
README.md Show resolved Hide resolved
@yfblock yfblock force-pushed the main branch 3 times, most recently from 285cb42 to 8abff93 Compare January 18, 2025 06:53
equation314
equation314 approved these changes Jan 18, 2025
View reviewed changes
Copy link
Member

@equation314 equation314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@equation314 equation314 merged commit d385519 into arceos-org:main Jan 18, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@equation314 equation314 equation314 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yfblock @equation314