Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: database backend add ssdb support #1280

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

neolynx
Copy link
Member

@neolynx neolynx commented Apr 20, 2024

Replaces #1115

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

@neolynx neolynx added needs review Ready for review & merge needs rebase The PR needs to be rebased on master fix tests Tests are failing and removed needs review Ready for review & merge labels Apr 20, 2024
@neolynx neolynx force-pushed the feature/support-ssdb branch from 9d2e29b to 38dfac1 Compare April 21, 2024 09:26
@neolynx neolynx removed the needs rebase The PR needs to be rebased on master label Apr 21, 2024
Copy link

codecov bot commented Apr 21, 2024

Codecov Report

Attention: Patch coverage is 72.35772% with 102 lines in your changes missing coverage. Please review.

Project coverage is 74.97%. Comparing base (cf3841e) to head (b5271ad).

Files with missing lines Patch % Lines
database/ssdb/storage.go 64.60% 31 Missing and 9 partials ⚠️
database/ssdb/transaction.go 81.60% 19 Missing and 4 partials ⚠️
database/ssdb/database.go 55.55% 12 Missing and 4 partials ⚠️
context/context.go 0.00% 15 Missing ⚠️
database/ssdb/batch.go 93.42% 4 Missing and 1 partial ⚠️
database/ssdb/log.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1280      +/-   ##
==========================================
- Coverage   75.03%   74.97%   -0.06%     
==========================================
  Files         158      163       +5     
  Lines       18356    18725     +369     
==========================================
+ Hits        13773    14040     +267     
- Misses       3445     3528      +83     
- Partials     1138     1157      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neolynx neolynx requested review from mfolusiak, szakalboss and a team April 21, 2024 11:09
@neolynx neolynx added needs review Ready for review & merge increase coverage The PR lacks test coverage and removed fix tests Tests are failing labels Apr 21, 2024
@neolynx neolynx force-pushed the feature/support-ssdb branch 2 times, most recently from 50e2a31 to 88d4563 Compare April 24, 2024 15:41
@neolynx neolynx self-assigned this Jun 13, 2024
@neolynx neolynx force-pushed the feature/support-ssdb branch from 88d4563 to 9c09966 Compare June 15, 2024 22:34
@neolynx neolynx force-pushed the feature/support-ssdb branch from f3520c0 to 049cd0a Compare June 17, 2024 19:11
@neolynx neolynx removed the increase coverage The PR lacks test coverage label Jun 17, 2024
@neolynx neolynx force-pushed the feature/support-ssdb branch from 049cd0a to 145d641 Compare July 3, 2024 16:26
@neolynx neolynx force-pushed the feature/support-ssdb branch 3 times, most recently from 3e63f55 to 5a43690 Compare July 31, 2024 20:17
@neolynx neolynx force-pushed the feature/support-ssdb branch from 5a43690 to 6d3b852 Compare August 11, 2024 11:56
@neolynx neolynx force-pushed the feature/support-ssdb branch 2 times, most recently from 95ece9c to 393712c Compare October 1, 2024 12:35
@neolynx neolynx force-pushed the feature/support-ssdb branch from 393712c to 106330e Compare October 3, 2024 21:39
@neolynx neolynx added needs tests and removed needs review Ready for review & merge labels Oct 8, 2024
@neolynx neolynx force-pushed the feature/support-ssdb branch from 106330e to 4a6f4bb Compare October 9, 2024 18:21
@neolynx neolynx force-pushed the feature/support-ssdb branch from 4a6f4bb to 15bf51e Compare October 22, 2024 19:07
@neolynx neolynx force-pushed the feature/support-ssdb branch from 15bf51e to bca154e Compare December 11, 2024 12:29
@neolynx neolynx force-pushed the feature/support-ssdb branch from bca154e to abbfd15 Compare December 24, 2024 23:14
@neolynx neolynx force-pushed the master branch 16 times, most recently from de022db to 4076941 Compare January 11, 2025 14:58
hudeng-go and others added 3 commits January 25, 2025 14:01
Change-Id: I054c5fc9b02f613601781de8613d684faa0ea7f2
Change-Id: I8534e66786021ce4384c92a2a8d14aa50839a4da
@neolynx neolynx force-pushed the feature/support-ssdb branch from abbfd15 to b5271ad Compare January 25, 2025 13:01
@neolynx neolynx added the help wanted ! Please help getting this PR merged :-) label Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted ! Please help getting this PR merged :-) needs tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants