Skip to content

Commit

Permalink
chore(reaper): add document about reaping
Browse files Browse the repository at this point in the history
1. change warn to info. The warning may confuse the user.
2. add document about reaping

#183
  • Loading branch information
qianlongzt committed Jan 30, 2025
1 parent 9cd9b36 commit 99808b5
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ implementations are ill-suited for container environments:
- They often try to send their logs to syslog. This conveniently provides
centralized logging when a syslog server is running, but with containers,
simply logging to `stdout` or `stderr` is preferred.
- Automate reaping [zombie processes](https://en.wikipedia.org/wiki/Zombie_process) when running as PID 1, which may cause them to accumulate in the process table, consuming system resources.

Finally, they are often quiet, making these issues difficult to understand and
debug!
Expand Down
5 changes: 3 additions & 2 deletions main.go
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,9 @@ func main() {
forkExec()
return
}

logrus.Warn("process reaping disabled, not pid 1")
// warning may confuse user
// https://github.com/aptible/supercronic/issues/183
logrus.Info("process reaping disabled, not pid 1.It's safe to ignore")
}
crontabFileName := flag.Args()[0]

Expand Down

0 comments on commit 99808b5

Please sign in to comment.