Update gamma kernel, add reproducibility CI test #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeverinDiederichs
added
bug
|
Can one of the admins verify this patch? |
SeverinDiederichs
changed the title
agheata
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the gamma kernel, which is a leftover from #324.
The
SampleInteractiononly needs to be called if no boundary is hit (as otherwise no physics process is used). This enables to keep thenumIALeftwhich is stored in thecurrentTrackand needs to be passed to the G4HepEm theTrack. The previous early exit with setting the winnerprocess to -1 caused non-reproducibility.Since the code is reproducible with this fix, the CI test for reproducibility with 8 ttbar events in CMS (no B field) is activated and replaced the previous test that just ran one event.
To do:
Physics validation results are just as before:
allGPUregion:
some layers as GPU region:
