Skip to content
This repository has been archived by the owner on Aug 6, 2024. It is now read-only.

feat: Added editable text #665

Merged
merged 4 commits into from
Oct 27, 2023
Merged

feat: Added editable text #665

merged 4 commits into from
Oct 27, 2023

Conversation

albinAppsmith
Copy link
Contributor

Description

Added editable component.

Fixes appsmithorg/appsmith#28096

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Manual on storybook
  • Manual on main repo
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

QA activity:

  • Test plan has been approved by relevant developers
  • Test plan has been peer reviewed by QA
  • Cypress test cases have been added and approved by either SDET or manual QA
  • Organized project review call with relevant stakeholders after Round 1/2 of QA
  • Added Test Plan Approved label after reveiwing all Cypress test

@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2023

⚠️ No Changeset found

Latest commit: 558fefb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2023 0:31am

jsartisan
jsartisan previously approved these changes Oct 26, 2023
`;

export const StyledEditableInput = styled.input`
&& {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why &&? 😅

jsartisan
jsartisan previously approved these changes Oct 26, 2023
@albinAppsmith albinAppsmith merged commit f63a3cd into release Oct 27, 2023
5 checks passed
@albinAppsmith albinAppsmith deleted the editable-text branch October 27, 2023 12:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Create editable text component in design system
3 participants