Skip to content
This repository has been archived by the owner on Aug 6, 2024. It is now read-only.

fix: Added z-index for table head #660

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Conversation

albinAppsmith
Copy link
Contributor

Description

Added z-index to sticky thead to avoid row components overlapping.

Fixes appsmithorg/appsmith#28014

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual on storybook
  • Manual on main repo
  • Jest
  • Cypress

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

QA activity:

  • Test plan has been approved by relevant developers
  • Test plan has been peer reviewed by QA
  • Cypress test cases have been added and approved by either SDET or manual QA
  • Organized project review call with relevant stakeholders after Round 1/2 of QA
  • Added Test Plan Approved label after reveiwing all Cypress test

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2023

🦋 Changeset detected

Latest commit: e455013

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@appsmithorg/design-system-old Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 5:39am

@github-actions github-actions bot added BE Coders Pod bug Something isn't working Deploy Preview High This issue blocks a user from building or impacts a lot of users Needs Triaging Data Platform Pod Custom environments labels Oct 24, 2023
@albinAppsmith
Copy link
Contributor Author

/generate-alpha

@github-actions
Copy link
Contributor

Publish Result: @appsmithorg/[email protected]

@albinAppsmith
Copy link
Contributor Author

/generate-alpha

@albinAppsmith albinAppsmith merged commit b8579e1 into release Oct 25, 2023
5 checks passed
@albinAppsmith albinAppsmith deleted the table-sticky-header-z-index branch October 25, 2023 04:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
BE Coders Pod bug Something isn't working Custom environments Data Platform Pod Deploy Preview Design System Pod High This issue blocks a user from building or impacts a lot of users Needs Triaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: UI overlap in manage environments page
2 participants