review comment fixes

appsmithorg · Oct 25, 2023 · b004483 · b004483
1 parent 37d9b33
commit b004483
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/packages/design-system/src/Table/Table.stories.tsx b/packages/design-system/src/Table/Table.stories.tsx
@@ -14,7 +14,7 @@ export default {
         style={{
           width: "60%",
           height: "50vh",
-          overflow: "scroll",
+          display: "table",
         }}
       >
         <Story />
@@ -315,6 +315,7 @@ export const TableStory: Story = {
       },
     ],
     sticky: true,
+    tableLayout: "fixed",
   },
   render: (args) => <Table {...args} />,
 };

diff --git a/packages/design-system/src/Table/Table.styles.tsx b/packages/design-system/src/Table/Table.styles.tsx
@@ -32,9 +32,9 @@ export const StyledHeaderCell = styled.th.attrs(({ className }) => ({
   className: clsx(TableHeaderCellClassName, className),
 }))`
   && {
-    font-size: 14px;
+    font-size: var(--ads-v2-font-size-4);
     font-style: normal;
-    font-weight: 400;
+    font-weight: var(--ads-v2-font-weight-normal);
     color: var(--ads-v2-colors-content-label-default-fg);
     font-family: var(--ads-v2-font-family);
     border: none;
@@ -60,7 +60,7 @@ export const StyledCell = styled.td.attrs(({ className }) => ({
   className: clsx(TableBodyCellClassName, className),
 }))`
   && {
-    font-size: 14px;
+    font-size: var(--ads-v2-font-size-4);
     padding: var(--ads-v2-spaces-6) var(--ads-v2-spaces-5);
     color: var(--ads-v2-colors-content-label-default-fg);
     font-family: var(--ads-v2-font-family);

diff --git a/packages/design-system/src/Table/Table.tsx b/packages/design-system/src/Table/Table.tsx
@@ -35,9 +35,7 @@ function Table({ className, emptyText = NoData, ...props }: TableProps) {
     },
   };
   return (
-    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-    // @ts-expect-error
-    <RcTable
+    <RcTable<any>
       {...props}
       className={clsx(TableWrapperClassName, className)}
       components={components}