test: adding test for page functionality #38538
Conversation
NandanAnantharamu
requested review from
ApekshaBhosale and
sagar-qa007
as code owners
WalkthroughThis pull request introduces a suite of Cypress end-to-end tests aimed at verifying page actions within a web application. The tests encompass various scenarios such as renaming, cloning, hiding pages, setting a page as the home page, and testing partial import/export functionality. The changes also include updates to the modal methods for opening export and import dialogs, allowing for dynamic entity names. Additionally, the test specification file has been modified to focus on these new page action tests. Changes
Possibly related PRs
Suggested Labels
Suggested Reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
/ci-test-limit-count run_count=1 |
github-actions
bot
added
skip-changelog
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/12668687355. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
app/client/cypress/e2e/Regression/ClientSide/PartialImportExport/PageActions_spec.ts(1 hunks)app/client/cypress/limited-tests.txt(1 hunks)app/client/cypress/support/Pages/PartialImportExport.ts(2 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
app/client/cypress/limited-tests.txt (1)
Pattern app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:
- Follow best practices for Cypress code and e2e automation.
- Avoid using cy.wait in code.
- Avoid using cy.pause in code.
- Avoid using agHelper.sleep().
- Use locator variables for locators and do not use plain strings.
- Use data-* attributes for selectors.
- Avoid Xpaths, Attributes and CSS path.
- Avoid selectors like .btn.submit or button[type=submit].
- Perform logins via API with LoginFromAPI.
- Perform logout via API with LogOutviaAPI.
- Perform signup via API with SignupFromAPI.
- Avoid using it.only.
- Avoid using after and aftereach in test cases.
- Use multiple assertions for expect statements.
- Avoid using strings for assertions.
- Do not use duplicate filenames even with different paths.
- Avoid using agHelper.Sleep, this.Sleep in any file in code.
app/client/cypress/support/Pages/PartialImportExport.ts (1)
Pattern app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:
- Follow best practices for Cypress code and e2e automation.
- Avoid using cy.wait in code.
- Avoid using cy.pause in code.
- Avoid using agHelper.sleep().
- Use locator variables for locators and do not use plain strings.
- Use data-* attributes for selectors.
- Avoid Xpaths, Attributes and CSS path.
- Avoid selectors like .btn.submit or button[type=submit].
- Perform logins via API with LoginFromAPI.
- Perform logout via API with LogOutviaAPI.
- Perform signup via API with SignupFromAPI.
- Avoid using it.only.
- Avoid using after and aftereach in test cases.
- Use multiple assertions for expect statements.
- Avoid using strings for assertions.
- Do not use duplicate filenames even with different paths.
- Avoid using agHelper.Sleep, this.Sleep in any file in code.
app/client/cypress/e2e/Regression/ClientSide/PartialImportExport/PageActions_spec.ts (1)
Pattern app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:
- Follow best practices for Cypress code and e2e automation.
- Avoid using cy.wait in code.
- Avoid using cy.pause in code.
- Avoid using agHelper.sleep().
- Use locator variables for locators and do not use plain strings.
- Use data-* attributes for selectors.
- Avoid Xpaths, Attributes and CSS path.
- Avoid selectors like .btn.submit or button[type=submit].
- Perform logins via API with LoginFromAPI.
- Perform logout via API with LogOutviaAPI.
- Perform signup via API with SignupFromAPI.
- Avoid using it.only.
- Avoid using after and aftereach in test cases.
- Use multiple assertions for expect statements.
- Avoid using strings for assertions.
- Do not use duplicate filenames even with different paths.
- Avoid using agHelper.Sleep, this.Sleep in any file in code.
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: client-lint / client-lint
- GitHub Check: client-build / client-build
- GitHub Check: client-unit-tests / client-unit-tests
- GitHub Check: client-prettier / prettier-check
🔇 Additional comments (3)
app/client/cypress/support/Pages/PartialImportExport.ts (2)
Line range hint
39-50: LGTM! Method follows Cypress best practices.The implementation correctly uses data-testid selectors and avoids cy.wait/pause.
52-62: LGTM! Method follows Cypress best practices.The implementation correctly uses data-testid selectors and avoids cy.wait/pause.
app/client/cypress/limited-tests.txt (1)
2-2: LGTM! Test specification correctly added.The new test specification is properly formatted and aligns with the PR objective.
| partialImportExport.locators.export.modelContents.widgetsSection, | ||
| ["Text1"], | ||
| ); | ||
| cy.wait(5000); |
There was a problem hiding this comment.
Remove hardcoded wait time
Replace cy.wait(5000) with proper assertions or intercepts to make the test more reliable.
Consider using:
-cy.wait(5000);
+agHelper.AssertElementVisibility(locators._successIndicator);Committable suggestion skipped: line range outside the PR's diff.
| partialImportExport.locators.export.modelContents.widgetsSection, | ||
| ["Text1"], | ||
| ); | ||
| cy.wait(5000); |
There was a problem hiding this comment.
Remove hardcoded wait time
Replace cy.wait(5000) with proper assertions or intercepts to make the test more reliable.
Consider using:
-cy.wait(5000);
+agHelper.AssertElementVisibility(locators._successIndicator);Committable suggestion skipped: line range outside the PR's diff.
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12668687355. |
|
/ci-test-limit-count run_count=5 |
|
/ci-test-limit-count run_count=5 |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/12694533445. |
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
app/client/cypress/support/Pages/PartialImportExport.ts (1)
Line range hint
1-200: Address Cypress best practices violationsThe class contains several Cypress anti-patterns that should be addressed:
- Replace xpath selectors with data-testid attributes
- Remove cy.wait in favor of route aliases or assertions
- Centralize error messages in a constants file
Example improvements:
- cy.xpath(this.homePage._uploadFile) + cy.get('[data-testid="upload-file-input"]') - cy.wait("@partialImportNetworkCall"); + cy.wait("@partialImportNetworkCall").its('response.statusCode').should('eq', 200); - "Internal server error while processing request" + MESSAGES.INTERNAL_SERVER_ERROR
🧹 Nitpick comments (1)
app/client/cypress/support/Pages/PartialImportExport.ts (1)
39-41: Consider extracting default page name to a constantThe hardcoded "Home" value should be defined as a class constant for better maintainability.
+ private readonly DEFAULT_HOME_PAGE = "Home"; - OpenExportModal(entityName = "Home") { + OpenExportModal(entityName = this.DEFAULT_HOME_PAGE) {
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
app/client/cypress/support/Pages/PartialImportExport.ts(2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
app/client/cypress/support/Pages/PartialImportExport.ts (1)
Pattern app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:
- Follow best practices for Cypress code and e2e automation.
- Avoid using cy.wait in code.
- Avoid using cy.pause in code.
- Avoid using agHelper.sleep().
- Use locator variables for locators and do not use plain strings.
- Use data-* attributes for selectors.
- Avoid Xpaths, Attributes and CSS path.
- Avoid selectors like .btn.submit or button[type=submit].
- Perform logins via API with LoginFromAPI.
- Perform logout via API with LogOutviaAPI.
- Perform signup via API with SignupFromAPI.
- Avoid using it.only.
- Avoid using after and aftereach in test cases.
- Use multiple assertions for expect statements.
- Avoid using strings for assertions.
- Do not use duplicate filenames even with different paths.
- Avoid using agHelper.Sleep, this.Sleep in any file in code.
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: perform-test / client-build / client-build
- GitHub Check: client-unit-tests / client-unit-tests
- GitHub Check: client-lint / client-lint
- GitHub Check: client-build / client-build
| OpenImportModal(entityName = "Page1") { | ||
| AppSidebar.navigate(AppSidebarButton.Editor); | ||
|
|
||
| this.entityExplorer.ActionContextMenuByEntityName({ | ||
| entityNameinLeftSidebar: "Page1", | ||
| entityNameinLeftSidebar: entityName, |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Extract default page name and remove redundant method
Similar to the export modal, the default page name should be a constant. Additionally, the OpenImportModalWithPage method at the bottom of the file is now redundant.
+ private readonly DEFAULT_IMPORT_PAGE = "Page1";
- OpenImportModal(entityName = "Page1") {
+ OpenImportModal(entityName = this.DEFAULT_IMPORT_PAGE) {Please remove the redundant OpenImportModalWithPage method as its functionality is now covered by OpenImportModal.
Committable suggestion skipped: line range outside the PR's diff.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
app/client/cypress/e2e/Regression/ClientSide/PartialImportExport/PageActions_spec.ts (1)
17-79: Test structure follows best practices but needs DRY refactoringThe test cases have similar steps that could be extracted into reusable helper functions to reduce code duplication. Consider creating helper functions for common operations like:
- Page verification steps
- Export/Import verification steps
Example helper function:
function verifyPageActions(pageName: string) { PageList.ClonePage(pageName); PageList.HidePage(`${pageName} Copy`); PageList.ShowList(); agHelper.AssertAttribute( locators._entityTestId(`${pageName} Copy`), "disabled", "disabled" ); PageList.DeletePage(`${pageName} Copy`); PageList.assertAbsence(`${pageName} Copy`); }Also applies to: 81-101, 103-140
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
app/client/cypress/e2e/Regression/ClientSide/PartialImportExport/PageActions_spec.ts(1 hunks)app/client/cypress/support/Objects/CommonLocators.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
app/client/cypress/support/Objects/CommonLocators.ts (1)
Pattern app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:
- Follow best practices for Cypress code and e2e automation.
- Avoid using cy.wait in code.
- Avoid using cy.pause in code.
- Avoid using agHelper.sleep().
- Use locator variables for locators and do not use plain strings.
- Use data-* attributes for selectors.
- Avoid Xpaths, Attributes and CSS path.
- Avoid selectors like .btn.submit or button[type=submit].
- Perform logins via API with LoginFromAPI.
- Perform logout via API with LogOutviaAPI.
- Perform signup via API with SignupFromAPI.
- Avoid using it.only.
- Avoid using after and aftereach in test cases.
- Use multiple assertions for expect statements.
- Avoid using strings for assertions.
- Do not use duplicate filenames even with different paths.
- Avoid using agHelper.Sleep, this.Sleep in any file in code.
app/client/cypress/e2e/Regression/ClientSide/PartialImportExport/PageActions_spec.ts (1)
Pattern app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:
- Follow best practices for Cypress code and e2e automation.
- Avoid using cy.wait in code.
- Avoid using cy.pause in code.
- Avoid using agHelper.sleep().
- Use locator variables for locators and do not use plain strings.
- Use data-* attributes for selectors.
- Avoid Xpaths, Attributes and CSS path.
- Avoid selectors like .btn.submit or button[type=submit].
- Perform logins via API with LoginFromAPI.
- Perform logout via API with LogOutviaAPI.
- Perform signup via API with SignupFromAPI.
- Avoid using it.only.
- Avoid using after and aftereach in test cases.
- Use multiple assertions for expect statements.
- Avoid using strings for assertions.
- Do not use duplicate filenames even with different paths.
- Avoid using agHelper.Sleep, this.Sleep in any file in code.
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: perform-test / client-build / client-build
- GitHub Check: perform-test / rts-build / build
- GitHub Check: perform-test / server-build / server-unit-tests
- GitHub Check: client-unit-tests / client-unit-tests
- GitHub Check: client-lint / client-lint
- GitHub Check: client-prettier / prettier-check
- GitHub Check: client-build / client-build
🔇 Additional comments (4)
app/client/cypress/support/Objects/CommonLocators.ts (1)
355-355: LGTM! Well-defined locator using data-testidThe new locator follows best practices by using data-testid attribute for test selection.
app/client/cypress/e2e/Regression/ClientSide/PartialImportExport/PageActions_spec.ts (3)
1-16: LGTM! Well-organized importsThe imports are properly organized and use named imports for better code organization.
69-69: Remove hardcoded wait timeReplace cy.wait(5000) with proper assertions or intercepts to make the test more reliable.
-cy.wait(5000); +agHelper.AssertElementVisibility(locators._successIndicator);
130-130: Remove hardcoded wait timeReplace cy.wait(5000) with proper assertions or intercepts to make the test more reliable.
-cy.wait(5000); +agHelper.AssertElementVisibility(locators._successIndicator);
|
/ci-test-limit-count run_count=5 |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/12695142338. |
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12694533445. |
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12695142338. |
|
/ci-test-limit-count run_count=5 |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/12703244768. |
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12703244768. |
| partialImportExport.locators.export.modelContents.widgetsSection, | ||
| ["Text1"], | ||
| ); | ||
| cy.wait(5000); |
There was a problem hiding this comment.
Can we try to remove this sleep? or add proper reason behind this sleep?
|
/ci-test-limit-count run_count=5 |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/12710653022. |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
app/client/cypress/e2e/Regression/ClientSide/PartialImportExport/PageActions_spec.ts (2)
64-68: Remove magic number and improve export parametersThe number 4 is used without context. Consider using a named constant or configuration value.
- partialImportExport.PartiallyExportFile( - 4, - partialImportExport.locators.export.modelContents.widgetsSection, - ["Text1"], - ); + const WIDGET_EXPORT_CONFIG = { + version: 4, + section: partialImportExport.locators.export.modelContents.widgetsSection, + widgets: ["Text1"], + }; + partialImportExport.PartiallyExportFile( + WIDGET_EXPORT_CONFIG.version, + WIDGET_EXPORT_CONFIG.section, + WIDGET_EXPORT_CONFIG.widgets, + );
80-100: Add error handling for page navigationConsider adding error handling for page navigation failures and assertions.
- EditorNavigation.NavigateToPage("Page1", true); + cy.intercept('GET', '**/page/*').as('pageLoad'); + EditorNavigation.NavigateToPage("Page1", true); + cy.wait('@pageLoad').then((interception) => { + expect(interception.response.statusCode).to.eq(200); + });
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
app/client/cypress/e2e/Regression/ClientSide/PartialImportExport/PageActions_spec.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
app/client/cypress/e2e/Regression/ClientSide/PartialImportExport/PageActions_spec.ts (1)
Pattern app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:
- Follow best practices for Cypress code and e2e automation.
- Avoid using cy.wait in code.
- Avoid using cy.pause in code.
- Avoid using agHelper.sleep().
- Use locator variables for locators and do not use plain strings.
- Use data-* attributes for selectors.
- Avoid Xpaths, Attributes and CSS path.
- Avoid selectors like .btn.submit or button[type=submit].
- Perform logins via API with LoginFromAPI.
- Perform logout via API with LogOutviaAPI.
- Perform signup via API with SignupFromAPI.
- Avoid using it.only.
- Avoid using after and aftereach in test cases.
- Use multiple assertions for expect statements.
- Avoid using strings for assertions.
- Do not use duplicate filenames even with different paths.
- Avoid using agHelper.Sleep, this.Sleep in any file in code.
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: client-unit-tests / client-unit-tests
- GitHub Check: client-build / client-build
- GitHub Check: client-lint / client-lint
- GitHub Check: client-prettier / prettier-check
🔇 Additional comments (2)
app/client/cypress/e2e/Regression/ClientSide/PartialImportExport/PageActions_spec.ts (2)
1-16: Clean imports structure!The imports are well-organized and follow consistent patterns.
103-103: Duplicate coordinate issueSame issue with hardcoded coordinates as in test case 1.
| it("1. Verify Page Actions when a page is selected", function () { | ||
| homePage.RenameApplication("PageActions"); | ||
| PageList.AddNewPage("New blank page"); | ||
| entityExplorer.DragDropWidgetNVerify(draggableWidgets.TEXT, 500, 100); |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Avoid using hardcoded coordinates for widget placement
Using fixed coordinates (500, 100) makes the test brittle and susceptible to viewport size changes.
-entityExplorer.DragDropWidgetNVerify(draggableWidgets.TEXT, 500, 100);
+entityExplorer.DragDropWidgetNVerify(draggableWidgets.TEXT);Committable suggestion skipped: line range outside the PR's diff.
| partialImportExport.OpenExportModal("HomePage"); | ||
| partialImportExport.PartiallyExportFile( | ||
| 4, | ||
| partialImportExport.locators.export.modelContents.widgetsSection, | ||
| ["Text1"], | ||
| ); | ||
|
|
||
| //Import the exported App | ||
| partialImportExport.OpenImportModal("HomePage"); | ||
| partialImportExport.ImportPartiallyExportedFile( | ||
| "PageActions.json", | ||
| "Widgets", | ||
| ["Text1"], | ||
| "downloads", | ||
| ); |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Extract export/import logic to reusable helper
The export/import logic is duplicated from test case 1. Consider extracting it to a reusable helper function.
+const performWidgetExportImport = (pageName: string, widgetNames: string[]) => {
+ partialImportExport.OpenExportModal(pageName);
+ partialImportExport.PartiallyExportFile(
+ 4,
+ partialImportExport.locators.export.modelContents.widgetsSection,
+ widgetNames,
+ );
+
+ partialImportExport.OpenImportModal(pageName);
+ partialImportExport.ImportPartiallyExportedFile(
+ "PageActions.json",
+ "Widgets",
+ widgetNames,
+ "downloads",
+ );
+};
+
- partialImportExport.OpenExportModal("HomePage");
- partialImportExport.PartiallyExportFile(
- 4,
- partialImportExport.locators.export.modelContents.widgetsSection,
- ["Text1"],
- );
-
- //Import the exported App
- partialImportExport.OpenImportModal("HomePage");
- partialImportExport.ImportPartiallyExportedFile(
- "PageActions.json",
- "Widgets",
- ["Text1"],
- "downloads",
- );
+ performWidgetExportImport("HomePage", ["Text1"]);📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| partialImportExport.OpenExportModal("HomePage"); | |
| partialImportExport.PartiallyExportFile( | |
| 4, | |
| partialImportExport.locators.export.modelContents.widgetsSection, | |
| ["Text1"], | |
| ); | |
| //Import the exported App | |
| partialImportExport.OpenImportModal("HomePage"); | |
| partialImportExport.ImportPartiallyExportedFile( | |
| "PageActions.json", | |
| "Widgets", | |
| ["Text1"], | |
| "downloads", | |
| ); | |
| const performWidgetExportImport = (pageName: string, widgetNames: string[]) => { | |
| partialImportExport.OpenExportModal(pageName); | |
| partialImportExport.PartiallyExportFile( | |
| 4, | |
| partialImportExport.locators.export.modelContents.widgetsSection, | |
| widgetNames, | |
| ); | |
| partialImportExport.OpenImportModal(pageName); | |
| partialImportExport.ImportPartiallyExportedFile( | |
| "PageActions.json", | |
| "Widgets", | |
| widgetNames, | |
| "downloads", | |
| ); | |
| }; | |
| performWidgetExportImport("HomePage", ["Text1"]); |
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12710653022. |
|
/ci-test-limit-count run_count=5 |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/12732016623. |
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12732016623. |
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
app/client/cypress/limited-tests.txt (1)
Line range hint
1-6: Update test specification to match PR objectivesThe current configuration runs Anvil/Widgets tests, but based on the PR objectives, we should be running the page functionality tests.
Apply this change to run the correct test file:
# To run only limited tests - give the spec names in below format: #cypress/e2e/Regression/ClientSide/VisualTests/JSEditorIndent_spec.js # For running all specs - uncomment below: #cypress/e2e/**/**/* -cypress/e2e/Regression/ClientSide/Anvil/Widgets/* +cypress/e2e/Regression/ClientSide/PartialImportExport/PageActions_spec.ts🧰 Tools
🪛 LanguageTool
[uncategorized] ~7-~7: You might be missing the article “the” here.
Context: ...ile to run minimum of specs. Do not run entire suite with this command.(AI_EN_LECTOR_MISSING_DETERMINER_THE)
🧹 Nitpick comments (1)
app/client/cypress/limited-tests.txt (1)
7-7: Fix grammar in the commentAdd the missing article "the" before "minimum".
-#ci-test-limit uses this file to run minimum of specs. Do not run entire suite with this command. +#ci-test-limit uses this file to run the minimum of specs. Do not run entire suite with this command.🧰 Tools
🪛 LanguageTool
[uncategorized] ~7-~7: You might be missing the article “the” here.
Context: ...ile to run minimum of specs. Do not run entire suite with this command.(AI_EN_LECTOR_MISSING_DETERMINER_THE)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
app/client/cypress/limited-tests.txt(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
app/client/cypress/limited-tests.txt (1)
Pattern app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:
- Follow best practices for Cypress code and e2e automation.
- Avoid using cy.wait in code.
- Avoid using cy.pause in code.
- Avoid using agHelper.sleep().
- Use locator variables for locators and do not use plain strings.
- Use data-* attributes for selectors.
- Avoid Xpaths, Attributes and CSS path.
- Avoid selectors like .btn.submit or button[type=submit].
- Perform logins via API with LoginFromAPI.
- Perform logout via API with LogOutviaAPI.
- Perform signup via API with SignupFromAPI.
- Avoid using it.only.
- Avoid using after and aftereach in test cases.
- Use multiple assertions for expect statements.
- Avoid using strings for assertions.
- Do not use duplicate filenames even with different paths.
- Avoid using agHelper.Sleep, this.Sleep in any file in code.
🪛 LanguageTool
app/client/cypress/limited-tests.txt
[uncategorized] ~7-~7: You might be missing the article “the” here.
Context: ...ile to run minimum of specs. Do not run entire suite with this command.
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: perform-test / rts-build / build
- GitHub Check: perform-test / server-build / server-unit-tests
- GitHub Check: client-unit-tests / client-unit-tests
- GitHub Check: client-prettier / prettier-check
- GitHub Check: client-lint / client-lint
- GitHub Check: client-build / client-build
NandanAnantharamu
added
ok-to-test
/ok-to-test tags="@tag.Sanity"
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12745705423
Commit: 88c823d
Cypress dashboard.
Tags:
@tag.SanitySpec:
Mon, 13 Jan 2025 11:37:45 UTC
Summary by CodeRabbit
New Features
Tests
Improvements