Mark _NameMap and supporting types as Sendable.
#1577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this is the rest of the issues in apple#1560 This is the different approach discussed in apple#1564.
thomasvl
force-pushed
the
NameMap_sendable
branch
from
5720244 to
688b640
Compare
|
Rebased over the CI issues, so should be easier to review/trust CI. |
Lukasa
approved these changes
Mar 18, 2024
FranzBusch
approved these changes
Mar 19, 2024
|
Are we planning a backport for this? |
#1583 should do that, just needs approvals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is the rest of the issues in #1560
This is the different approach discussed in #1564.