Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare MessageIdentificationShiftWrapper to be Sendable #778

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Declare MessageIdentificationShiftWrapper to be Sendable #778

merged 1 commit into from
Jan 6, 2025

Conversation

mdiep
Copy link
Collaborator

@mdiep mdiep commented Jan 6, 2025

Add a Sendable conformance to MessageIdentificationShiftWrapper.

Motivation:

Even though this isn't a public type, it's declared to be usable from inline, so its sendability matters externally.

danieleggert
danieleggert approved these changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@danieleggert danieleggert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mdiep mdiep added the semver/patch No public API change. label Jan 6, 2025
@danieleggert danieleggert added size/S Small task. (A couple of hours of work.) semver/none No version bump required. and removed semver/patch No public API change. labels Jan 6, 2025
@mdiep mdiep merged commit 5b2a96a into main Jan 6, 2025
24 of 26 checks passed
@mdiep mdiep deleted the MessageIdentificationShiftWrapper-Sendable branch January 6, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieleggert danieleggert danieleggert approved these changes

Assignees
No one assigned
Labels
semver/none No version bump required. size/S Small task. (A couple of hours of work.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdiep @danieleggert