Enable strict concurrency #213
Conversation
Motivation: To catch potential data races at build time. Modifications: - Bump Swift tools version from 5.8 to 5.9 in Package.swift. - Enable strict concurrency in Package.swift. - Adjust documentation to section on the supported Swift versions. - Implement minor fixes for the surfaced strict concurrency warnings. - Add `-require-explicit-sendable` to the 6.0, nightly 6.0 and nightly main CI checks. Result: Strict concurrency adoption.
Tests/X509Tests/SignatureTests.swift
Outdated
| @@ -12,7 +12,7 @@ | |||
| // | |||
| //===----------------------------------------------------------------------===// | |||
|
|
|||
| import XCTest | |||
| @preconcurrency import XCTest | |||
There was a problem hiding this comment.
I'm not convinced this is right. What errors did this silence?
There was a problem hiding this comment.
These:
Static property 'secKeyRSA' is not concurrency-safe because non-'Sendable' type 'SecKey?' may have shared mutable state; this is an error in the Swift 6 language mode
There was a problem hiding this comment.
Ah, we have a missing import. Instead of putting @preconcurrency here, please add this:
#if canImport(Darwin)
@preconcurrency import Security
#endif
| @@ -12,7 +12,7 @@ | |||
| // | |||
| //===----------------------------------------------------------------------===// | |||
|
|
|||
| import XCTest | |||
| @preconcurrency import XCTest | |||
There was a problem hiding this comment.
Similarly I'm not convinced this is right, what errors did this silence?
.github/workflows/main.yml
Outdated
| @@ -13,9 +13,9 @@ jobs: | |||
| with: | |||
| linux_5_9_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error" | |||
| linux_5_10_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error" | |||
There was a problem hiding this comment.
We have to lose warnings-as-errors on 5.10, as we can no longer maintain it with this change.
.github/workflows/main.yml
Outdated
| linux_6_0_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error" | ||
| linux_nightly_6_0_arguments_override: "--explicit-target-dependency-import-check error" | ||
| linux_nightly_main_arguments_override: "--explicit-target-dependency-import-check error" | ||
| linux_5_10_arguments_override: "-Xswiftc --explicit-target-dependency-import-check error" |
There was a problem hiding this comment.
Missed removing the -Xswiftc
Motivation:
To catch potential data races at build time.
Modifications:
-require-explicit-sendableto the 6.0, nightly 6.0 and nightly main CI checks.Result:
Strict concurrency adoption.