Fix flaky test CertificateTests.testCertificateDescription
#212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The test fails when the local machine is not set to 24-hour time. Modifications: - Adjust the test to use dynamic time values based on Foundation's `Date` instead of hard-coded time strings. Result: A non-flaky test.
Lukasa
approved these changes
Dec 11, 2024
clintonpi
deleted the
flaky-test/CertificateTests.testCertificateDescription
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The test fails when the local machine is not set to 24-hour time.
Modifications:
Dateinstead of hard-coded time strings.Result:
A non-flaky test.